From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: cl@linux.com, linux-mm@kvack.org, alex.shi@intel.com,
yanmin_zhang@linux.intel.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, rjw@sisk.pl
Subject: Re: [PATCH v2] slub: move kmem_cache_node into it's own cacheline
Date: Sat, 22 May 2010 11:35:45 +0300 [thread overview]
Message-ID: <4BF79761.5000402@cs.helsinki.fi> (raw)
In-Reply-To: <20100521214135.23902.55360.stgit@gitlad.jf.intel.com>
Alexander Duyck wrote:
> This patch is meant to improve the performance of SLUB by moving the local
> kmem_cache_node lock into it's own cacheline separate from kmem_cache.
> This is accomplished by simply removing the local_node when NUMA is enabled.
>
> On my system with 2 nodes I saw around a 5% performance increase w/
> hackbench times dropping from 6.2 seconds to 5.9 seconds on average. I
> suspect the performance gain would increase as the number of nodes
> increases, but I do not have the data to currently back that up.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Thanks for the fix, Alexander!
Yanmin and Alex, can I have your Tested-by or Acked-by please so we can
close "[Bug #15713] hackbench regression due to commit 9dfc6e68bfe6e"
after this patch is merged?
Pekka
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: cl@linux.com, linux-mm@kvack.org, alex.shi@intel.com,
yanmin_zhang@linux.intel.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, rjw@sisk.pl
Subject: Re: [PATCH v2] slub: move kmem_cache_node into it's own cacheline
Date: Sat, 22 May 2010 11:35:45 +0300 [thread overview]
Message-ID: <4BF79761.5000402@cs.helsinki.fi> (raw)
In-Reply-To: <20100521214135.23902.55360.stgit@gitlad.jf.intel.com>
Alexander Duyck wrote:
> This patch is meant to improve the performance of SLUB by moving the local
> kmem_cache_node lock into it's own cacheline separate from kmem_cache.
> This is accomplished by simply removing the local_node when NUMA is enabled.
>
> On my system with 2 nodes I saw around a 5% performance increase w/
> hackbench times dropping from 6.2 seconds to 5.9 seconds on average. I
> suspect the performance gain would increase as the number of nodes
> increases, but I do not have the data to currently back that up.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Thanks for the fix, Alexander!
Yanmin and Alex, can I have your Tested-by or Acked-by please so we can
close "[Bug #15713] hackbench regression due to commit 9dfc6e68bfe6e"
after this patch is merged?
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-22 8:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 21:41 [PATCH v2] slub: move kmem_cache_node into it's own cacheline Alexander Duyck
2010-05-22 8:35 ` Pekka Enberg [this message]
2010-05-22 8:35 ` Pekka Enberg
2010-05-23 13:15 ` Shi, Alex
2010-05-23 13:15 ` Shi, Alex
2010-05-24 13:52 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF79761.5000402@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rjw@sisk.pl \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.