[PATCH] pci: disable MSI on VIA K8M800

[PATCH] pci: disable MSI on VIA K8M800

[Tejun Heo]

MSI delivery from on-board ahci controller doesn't work on K8M800.  At
this point, it's unclear whether the culprit is with the ahci
controller or the host bridge.  Given the track record and considering
the rather minimal impact of MSI, disabling it seems reasonable.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Rainer Hurtado Navarro <publio.escipion.el.africano@gmail.com>
Cc: stable@kernel.org
---
Maybe we should whitelist working ones from via rather than the other
way around.  :-(

 drivers/pci/quirks.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 27c0e6e..18a661d 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2112,6 +2112,7 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS480, quirk_disabl
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT3336, quirk_disable_all_msi);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT3351, quirk_disable_all_msi);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT3364, quirk_disable_all_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8380_0, quirk_disable_all_msi);

 /* Disable MSI on chipsets that are known to not support it */
 static void __devinit quirk_disable_msi(struct pci_dev *dev)

Re: [PATCH] pci: disable MSI on VIA K8M800

[David Miller]

From: Tejun Heo <tj@kernel.org>
Date: Sun, 23 May 2010 10:22:55 +0200

> MSI delivery from on-board ahci controller doesn't work on K8M800.  At
> this point, it's unclear whether the culprit is with the ahci
> controller or the host bridge.  Given the track record and considering
> the rather minimal impact of MSI, disabling it seems reasonable.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Rainer Hurtado Navarro <publio.escipion.el.africano@gmail.com>
> Cc: stable@kernel.org
> ---
> Maybe we should whitelist working ones from via rather than the other
> way around.  :-(

Correctness first, of course, but saying the impact of MSI is minimal
ignores the fact that no hardware multiqueue networking at all is
possible without it. :-)

Re: [PATCH] pci: disable MSI on VIA K8M800

[Tejun Heo]

On 05/23/2010 10:54 AM, David Miller wrote:
> Correctness first, of course, but saying the impact of MSI is minimal
> ignores the fact that no hardware multiqueue networking at all is
> possible without it. :-)

If you're trying to do hw multiqueue networking on via chipset, you
gotta be on something *really* good.  Come on.  Share it with me.  :-)

-- 
tejun

Re: [PATCH] pci: disable MSI on VIA K8M800

[David Miller]

From: Tejun Heo <tj@kernel.org>
Date: Sun, 23 May 2010 10:56:58 +0200

> On 05/23/2010 10:54 AM, David Miller wrote:
>> Correctness first, of course, but saying the impact of MSI is minimal
>> ignores the fact that no hardware multiqueue networking at all is
>> possible without it. :-)
> 
> If you're trying to do hw multiqueue networking on via chipset, you
> gotta be on something *really* good.  Come on.  Share it with me.  :-)

Fair enough. :)

Re: [PATCH] pci: disable MSI on VIA K8M800

[Jesse Barnes]

On Sun, 23 May 2010 10:22:55 +0200
Tejun Heo <tj@kernel.org> wrote:

> MSI delivery from on-board ahci controller doesn't work on K8M800.  At
> this point, it's unclear whether the culprit is with the ahci
> controller or the host bridge.  Given the track record and considering
> the rather minimal impact of MSI, disabling it seems reasonable.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Rainer Hurtado Navarro <publio.escipion.el.africano@gmail.com>
> Cc: stable@kernel.org
> ---

Applied to my for-linus branch, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center