From: Avi Kivity <avi@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Jan Kiszka <jan.kiszka@siemens.com>,
Prerna Saxena <prerna@linux.vnet.ibm.com>,
Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH 7/7] trace: Trace virtqueue operations
Date: Tue, 25 May 2010 16:52:34 +0300 [thread overview]
Message-ID: <4BFBD622.20100@redhat.com> (raw)
In-Reply-To: <AANLkTim98TWkzQoK_5y0zfDJTnsK-L6w9evP2niUp2DD@mail.gmail.com>
On 05/25/2010 04:27 PM, Stefan Hajnoczi wrote:
> On Tue, May 25, 2010 at 1:04 PM, Avi Kivity<avi@redhat.com> wrote:
>
>> Those %ps are more or less useless. We need better ways of identifying
>> them.
>>
> You're right, the vq pointer is useless in isolation. We don't know
> which virtio device or which virtqueue number.
>
> With the full context of a trace it would be possible to correlate the
> vq pointer if we had trace events for vdev and vq setup.
>
> Adding custom formatters is could be tricky since the format string is
> passed only to tracing backends that use it, like UST. And UST uses
> its own sprintf implementation which we don't have direct control
> over.
>
Hm. Perhaps we can convert %{type} to %p for backends which don't
support it, and to whatever format they do support for those that do.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Prerna Saxena <prerna@linux.vnet.ibm.com>
Subject: [Qemu-devel] Re: [PATCH 7/7] trace: Trace virtqueue operations
Date: Tue, 25 May 2010 16:52:34 +0300 [thread overview]
Message-ID: <4BFBD622.20100@redhat.com> (raw)
In-Reply-To: <AANLkTim98TWkzQoK_5y0zfDJTnsK-L6w9evP2niUp2DD@mail.gmail.com>
On 05/25/2010 04:27 PM, Stefan Hajnoczi wrote:
> On Tue, May 25, 2010 at 1:04 PM, Avi Kivity<avi@redhat.com> wrote:
>
>> Those %ps are more or less useless. We need better ways of identifying
>> them.
>>
> You're right, the vq pointer is useless in isolation. We don't know
> which virtio device or which virtqueue number.
>
> With the full context of a trace it would be possible to correlate the
> vq pointer if we had trace events for vdev and vq setup.
>
> Adding custom formatters is could be tricky since the format string is
> passed only to tracing backends that use it, like UST. And UST uses
> its own sprintf implementation which we don't have direct control
> over.
>
Hm. Perhaps we can convert %{type} to %p for backends which don't
support it, and to whatever format they do support for those that do.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-05-25 13:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 10:24 [PATCH v2 0/7] Tracing backends Stefan Hajnoczi
2010-05-25 10:24 ` [Qemu-devel] " Stefan Hajnoczi
2010-05-25 10:24 ` [PATCH 1/7] trace: Add trace-events file for declaring trace events Stefan Hajnoczi
2010-05-25 10:24 ` [Qemu-devel] " Stefan Hajnoczi
2010-06-08 6:34 ` [PATCH] Re: Tracing backends : Fix for building with --prefix Prerna Saxena
2010-06-08 6:34 ` [Qemu-devel] " Prerna Saxena
2010-06-15 13:49 ` Stefan Hajnoczi
2010-06-15 13:49 ` [Qemu-devel] " Stefan Hajnoczi
2010-05-25 10:24 ` [PATCH 2/7] trace: Support disabled events in trace-events Stefan Hajnoczi
2010-05-25 10:24 ` [Qemu-devel] " Stefan Hajnoczi
2010-05-25 10:24 ` [PATCH 3/7] trace: Add simple built-in tracing backend Stefan Hajnoczi
2010-05-25 10:24 ` [Qemu-devel] " Stefan Hajnoczi
2010-05-25 10:24 ` [PATCH 4/7] trace: Add LTTng Userspace Tracer backend Stefan Hajnoczi
2010-05-25 10:24 ` [Qemu-devel] " Stefan Hajnoczi
2010-05-25 10:24 ` [PATCH 5/7] trace: Trace qemu_malloc() and qemu_vmalloc() Stefan Hajnoczi
2010-05-25 10:24 ` [Qemu-devel] " Stefan Hajnoczi
2010-05-25 10:24 ` [PATCH 6/7] trace: Trace virtio-blk, multiwrite, and paio_submit Stefan Hajnoczi
2010-05-25 10:24 ` [Qemu-devel] " Stefan Hajnoczi
2010-05-25 10:24 ` [PATCH 7/7] trace: Trace virtqueue operations Stefan Hajnoczi
2010-05-25 10:24 ` [Qemu-devel] " Stefan Hajnoczi
2010-05-25 12:04 ` Avi Kivity
2010-05-25 12:04 ` [Qemu-devel] " Avi Kivity
2010-05-25 13:27 ` Stefan Hajnoczi
2010-05-25 13:27 ` [Qemu-devel] " Stefan Hajnoczi
2010-05-25 13:52 ` Avi Kivity [this message]
2010-05-25 13:52 ` Avi Kivity
2010-05-25 14:00 ` Stefan Hajnoczi
2010-05-25 14:00 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFBD622.20100@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=prerna@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.