* [tabled patch 1/4] mark down nodes properly
@ 2010-05-22 2:19 Pete Zaitcev
2010-05-25 22:43 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Pete Zaitcev @ 2010-05-22 2:19 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Project Hail List
A simple assignment was forgotten, so tabled was expending a bit of
extra effort trying to contact nodes that are down.
Also, change the log level to match the line above.
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
---
server/server.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
commit 422fbb466a3e8e1599894069dff3dc50e189f7bd
Author: Pete Zaitcev <zaitcev@yahoo.com>
Date: Fri May 21 19:50:55 2010 -0600
Actually mark down nodes as down.
diff --git a/server/server.c b/server/server.c
index 1c7114a..4e8dba3 100644
--- a/server/server.c
+++ b/server/server.c
@@ -1499,9 +1499,10 @@ int stor_update_cb(void)
stn->up = true;
stn->last_up = time(NULL);
} else {
- if (stn->last_up != 0 &&
+ if (stn->up &&
time(NULL) >= stn->last_up + CHUNK_REBOOT_TIME) {
- applog(LOG_INFO, " NID %u went down", stn->id);
+ applog(LOG_DEBUG, " NID %u went down", stn->id);
+ stn->up = false;
}
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [tabled patch 1/4] mark down nodes properly
2010-05-22 2:19 [tabled patch 1/4] mark down nodes properly Pete Zaitcev
@ 2010-05-25 22:43 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2010-05-25 22:43 UTC (permalink / raw)
To: Pete Zaitcev; +Cc: Project Hail List
On 05/21/2010 10:19 PM, Pete Zaitcev wrote:
> A simple assignment was forgotten, so tabled was expending a bit of
> extra effort trying to contact nodes that are down.
>
> Also, change the log level to match the line above.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-25 22:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-22 2:19 [tabled patch 1/4] mark down nodes properly Pete Zaitcev
2010-05-25 22:43 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.