All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: kwolf@redhat.com, Paul Brook <paul@codesourcery.com>,
	qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
	hch@lst.de
Subject: Re: [Qemu-devel] Re: [PATCH] Add cache=volatile parameter to -drive
Date: Wed, 26 May 2010 11:11:53 -0500	[thread overview]
Message-ID: <4BFD4849.6050108@codemonkey.ws> (raw)
In-Reply-To: <4BFD40F3.7020406@aurel32.net>

On 05/26/2010 10:40 AM, Aurelien Jarno wrote:
>> I highly doubt that this is even visible on benchmarks without using
>> KVM.  The improvement on a microbenchmark was relatively small and the
>> cost from TCG would almost certainly dwarf it.
>>      
> It is something clearly visible. Before fsync() was not used, and it
> happens this syscall can be very expensive (ie a few seconds, especially
> with some other i/o load on the system) on ext3 with not so old kernels.
> A google search for "firefox fsync" will give you a few pointers.
>    

I'm well aware.  I've asked multiple times for benchmark data with ext3 
because of this issue.  So far, it hasn't been noticable.

>> Also, remember before KVM, we had single threaded IO and posix-aio
>> (which is still single threaded).  If KVM never happened, block
>> performance would be far, far worse than it is today with cache=writeback.
>>
>>      
> io thread is not enable by default in QEMU.
>    

But the thread pool based aio implementation is always enabled 
regardless of io thread.  I was going to build and run 0.9.1 to do a 
benchmark of TCG comparing that to the latest git, but I don't have an 
easy way to get a version of gcc-3.  I've forgotten how annoying that 
used to be :-)

I would be very surprised if TCG + IDE had any observable performance 
difference pre/post the ide flush implementation.  I'm almost inclined 
to suggestion that flush controls should be a qdev property verses a 
drive property since that's really where the change happened.

Regards,

Anthony Liguori

  reply	other threads:[~2010-05-26 16:11 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-17 10:14 [Qemu-devel] [PATCH] Add cache=volatile parameter to -drive Alexander Graf
2010-05-17 10:42 ` [Qemu-devel] " Kevin Wolf
2010-05-17 12:58 ` Anthony Liguori
2010-05-17 13:02   ` Alexander Graf
2010-05-17 13:09     ` Anthony Liguori
2010-05-17 13:17       ` Alexander Graf
2010-05-17 13:26         ` Anthony Liguori
2010-05-17 14:04           ` Alexander Graf
2010-05-17 14:22             ` Alexander Graf
2010-05-17 15:16             ` Anthony Liguori
2010-05-17 16:23               ` Paul Brook
2010-05-17 16:26                 ` Anthony Liguori
2010-05-17 16:28                   ` Alexander Graf
2010-05-17 20:07                     ` Jamie Lokier
2010-05-18  7:42                       ` Kevin Wolf
2010-05-25 17:59                   ` Alexander Graf
2010-05-25 18:48                     ` Anthony Liguori
2010-05-25 19:01                       ` Alexander Graf
2010-05-26 13:09                       ` Avi Kivity
2010-05-25 21:01                     ` Aurelien Jarno
2010-05-26  1:31                       ` Anthony Liguori
2010-05-26  8:43                         ` Kevin Wolf
2010-05-26 13:42                           ` Anthony Liguori
2010-05-26 14:03                             ` Kevin Wolf
2010-05-26 14:08                               ` Anthony Liguori
2010-05-26 14:26                                 ` Kevin Wolf
2010-05-26 14:13                               ` Aurelien Jarno
2010-05-26  8:52                         ` Aurelien Jarno
2010-05-26  9:16                           ` Kevin Wolf
2010-05-26 13:48                           ` Anthony Liguori
2010-05-26 14:12                             ` Aurelien Jarno
2010-05-26 14:19                               ` Anthony Liguori
2010-05-26 15:40                                 ` Aurelien Jarno
2010-05-26 16:11                                   ` Anthony Liguori [this message]
2010-05-26 14:27                             ` Paolo Bonzini
2010-05-26 13:06   ` Avi Kivity
2010-05-26 13:50     ` Anthony Liguori
2010-05-26 15:13       ` Avi Kivity
2010-05-17 15:11 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFD4849.6050108@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=hch@lst.de \
    --cc=kwolf@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.