From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Mel Gorman <mel@csn.ul.ie>,
Andrea Arcangeli <aarcange@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Subject: Re: [PATCH 5/5] extend KSM refcounts to the anon_vma root
Date: Thu, 27 May 2010 10:09:00 -0400 [thread overview]
Message-ID: <4BFE7CFC.4060706@redhat.com> (raw)
In-Reply-To: <20100527140212.GE2112@barrios-desktop>
On 05/27/2010 10:02 AM, Minchan Kim wrote:
> Hmm, I can understand this point.
> Now, rmap code always depeneds on root anon_vma's lock.
> I think it doesn't depends on KSM and MIGRATION.
>
> If we don't use KSM and MIGRATION and it is compiled out,
> Can root's anon_vma disappear during rmap walking?
> who prevent it?
>
> What am I missing?
unlink_anon_vmas walks the list in the order from newest
to oldest, ie. the root always gets unlinked (and potentially
freed) last.
--
All rights reversed
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Mel Gorman <mel@csn.ul.ie>,
Andrea Arcangeli <aarcange@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Subject: Re: [PATCH 5/5] extend KSM refcounts to the anon_vma root
Date: Thu, 27 May 2010 10:09:00 -0400 [thread overview]
Message-ID: <4BFE7CFC.4060706@redhat.com> (raw)
In-Reply-To: <20100527140212.GE2112@barrios-desktop>
On 05/27/2010 10:02 AM, Minchan Kim wrote:
> Hmm, I can understand this point.
> Now, rmap code always depeneds on root anon_vma's lock.
> I think it doesn't depends on KSM and MIGRATION.
>
> If we don't use KSM and MIGRATION and it is compiled out,
> Can root's anon_vma disappear during rmap walking?
> who prevent it?
>
> What am I missing?
unlink_anon_vmas walks the list in the order from newest
to oldest, ie. the root always gets unlinked (and potentially
freed) last.
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-27 14:11 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 19:38 [PATCH -v3 0/5] always lock the root anon_vma Rik van Riel
2010-05-26 19:38 ` Rik van Riel
2010-05-26 19:38 ` [PATCH 1/5] rename anon_vma_lock to vma_lock_anon_vma Rik van Riel
2010-05-26 19:38 ` Rik van Riel
2010-05-26 20:33 ` Larry Woodman
2010-05-26 20:33 ` Larry Woodman
2010-05-27 13:44 ` Minchan Kim
2010-05-27 13:44 ` Minchan Kim
2010-05-26 19:39 ` [PATCH 2/5] change direct call of spin_lock(anon_vma->lock) to inline function Rik van Riel
2010-05-26 19:39 ` Rik van Riel
2010-05-26 20:33 ` Larry Woodman
2010-05-26 20:33 ` Larry Woodman
2010-05-27 13:46 ` Minchan Kim
2010-05-27 13:46 ` Minchan Kim
2010-06-01 22:04 ` Andrew Morton
2010-06-01 22:04 ` Andrew Morton
2010-06-02 8:27 ` Peter Zijlstra
2010-06-02 8:27 ` Peter Zijlstra
2010-05-26 19:40 ` [PATCH 3/5] track the root (oldest) anon_vma Rik van Riel
2010-05-26 19:40 ` Rik van Riel
2010-05-26 20:34 ` Larry Woodman
2010-05-26 20:34 ` Larry Woodman
2010-05-27 13:48 ` Minchan Kim
2010-05-27 13:48 ` Minchan Kim
2010-05-26 19:40 ` [PATCH 4/5] always lock " Rik van Riel
2010-05-26 19:40 ` Rik van Riel
2010-05-26 20:36 ` Larry Woodman
2010-05-26 20:36 ` Larry Woodman
2010-05-27 0:57 ` KAMEZAWA Hiroyuki
2010-05-27 0:57 ` KAMEZAWA Hiroyuki
2010-05-27 13:55 ` Minchan Kim
2010-05-27 13:55 ` Minchan Kim
2010-05-27 17:48 ` Mel Gorman
2010-05-27 17:48 ` Mel Gorman
2010-05-26 19:41 ` [PATCH 5/5] extend KSM refcounts to the anon_vma root Rik van Riel
2010-05-26 19:41 ` Rik van Riel
2010-05-26 20:47 ` Larry Woodman
2010-05-26 20:47 ` Larry Woodman
2010-05-27 14:02 ` Minchan Kim
2010-05-27 14:02 ` Minchan Kim
2010-05-27 14:09 ` Rik van Riel [this message]
2010-05-27 14:09 ` Rik van Riel
2010-05-27 14:31 ` Minchan Kim
2010-05-27 14:31 ` Minchan Kim
2010-05-27 17:50 ` Mel Gorman
2010-05-27 17:50 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2010-05-12 17:38 [PATCH 0/5] always lock the root anon_vma Rik van Riel
2010-05-12 17:40 ` [PATCH 4/5] always lock the root (oldest) anon_vma Rik van Riel
2010-05-12 21:02 ` Mel Gorman
2010-05-12 21:08 ` Rik van Riel
2010-05-13 9:54 ` Mel Gorman
2010-05-13 14:33 ` [PATCH -v2 " Rik van Riel
2010-05-13 21:09 ` Andrew Morton
2010-05-26 4:00 ` Rik van Riel
2010-05-26 15:24 ` [PATCH -v2 0/5] always lock the root anon_vma Rik van Riel
2010-05-26 15:27 ` [PATCH 5/5] extend KSM refcounts to the anon_vma root Rik van Riel
2010-05-26 15:27 ` Rik van Riel
2010-05-12 17:41 ` Rik van Riel
2010-05-12 17:41 ` Rik van Riel
2010-05-12 21:07 ` Mel Gorman
2010-05-12 21:07 ` Mel Gorman
2010-05-12 21:09 ` Rik van Riel
2010-05-12 21:09 ` Rik van Riel
2010-05-13 11:26 ` Mel Gorman
2010-05-13 11:26 ` Mel Gorman
2010-05-13 13:11 ` Rik van Riel
2010-05-13 13:11 ` Rik van Riel
2010-05-13 13:24 ` Mel Gorman
2010-05-13 13:24 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFE7CFC.4060706@redhat.com \
--to=riel@redhat.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.