From: walter harms <wharms@bfs.de>
To: Dan Carpenter <error27@gmail.com>, Julia Lawall <julia@diku.dk>,
HighPoint Linux Team <linux@highpoint-tech.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-scsi@vger.ker
Subject: Re: [PATCH 7/11] drivers/scsi: Eliminate a NULL pointer dereference
Date: Thu, 27 May 2010 17:08:16 +0000 [thread overview]
Message-ID: <4BFEA700.20603@bfs.de> (raw)
In-Reply-To: <20100527165301.GU22515@bicker>
Dan Carpenter schrieb:
> On Thu, May 27, 2010 at 02:33:47PM +0200, Julia Lawall wrote:
>> If it is a problem to use 0 when host is NULL, then the code could be fixed
>> in another way.
>>
>
> Yeah. It seems like it would be better to give a clearly bogus number.
> I would have said -1 but "scsi-1" looks normal so maybe something like
> 9999999?
>
lets spend some bytes:
if (host)
dprintk("scsi%d: hptiop_probe failed\n",host->host_no);
else
dprintk("scsi: no host, hptiop_probe failed\n");
re,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <error27@gmail.com>, Julia Lawall <julia@diku.dk>,
HighPoint Linux Team <linux@highpoint-tech.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-scsi@vger.ker
Subject: Re: [PATCH 7/11] drivers/scsi: Eliminate a NULL pointer dereference
Date: Thu, 27 May 2010 19:08:16 +0200 [thread overview]
Message-ID: <4BFEA700.20603@bfs.de> (raw)
In-Reply-To: <20100527165301.GU22515@bicker>
Dan Carpenter schrieb:
> On Thu, May 27, 2010 at 02:33:47PM +0200, Julia Lawall wrote:
>> If it is a problem to use 0 when host is NULL, then the code could be fixed
>> in another way.
>>
>
> Yeah. It seems like it would be better to give a clearly bogus number.
> I would have said -1 but "scsi-1" looks normal so maybe something like
> 9999999?
>
lets spend some bytes:
if (host)
dprintk("scsi%d: hptiop_probe failed\n",host->host_no);
else
dprintk("scsi: no host, hptiop_probe failed\n");
re,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <error27@gmail.com>, Julia Lawall <julia@diku.dk>,
HighPoint Linux Team <linux@highpoint-tech.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 7/11] drivers/scsi: Eliminate a NULL pointer dereference
Date: Thu, 27 May 2010 19:08:16 +0200 [thread overview]
Message-ID: <4BFEA700.20603@bfs.de> (raw)
In-Reply-To: <20100527165301.GU22515@bicker>
Dan Carpenter schrieb:
> On Thu, May 27, 2010 at 02:33:47PM +0200, Julia Lawall wrote:
>> If it is a problem to use 0 when host is NULL, then the code could be fixed
>> in another way.
>>
>
> Yeah. It seems like it would be better to give a clearly bogus number.
> I would have said -1 but "scsi-1" looks normal so maybe something like
> 9999999?
>
lets spend some bytes:
if (host)
dprintk("scsi%d: hptiop_probe failed\n",host->host_no);
else
dprintk("scsi: no host, hptiop_probe failed\n");
re,
wh
next prev parent reply other threads:[~2010-05-27 17:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 12:33 [PATCH 7/11] drivers/scsi: Eliminate a NULL pointer dereference Julia Lawall
2010-05-27 12:33 ` Julia Lawall
2010-05-27 16:53 ` Dan Carpenter
2010-05-27 16:53 ` Dan Carpenter
2010-05-27 17:08 ` walter harms [this message]
2010-05-27 17:08 ` walter harms
2010-05-27 17:08 ` walter harms
2010-05-27 17:13 ` Julia Lawall
2010-05-27 17:13 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFEA700.20603@bfs.de \
--to=wharms@bfs.de \
--cc=James.Bottomley@suse.de \
--cc=error27@gmail.com \
--cc=julia@diku.dk \
--cc=linux-scsi@vger.ker \
--cc=linux@highpoint-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.