From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: Wan ZongShun <mcuos.com-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
alsa-devel <alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org>
Subject: Re: [PATCH] ALSA/davinci: Use the resource_size , __devinit and __devexit.
Date: Fri, 28 May 2010 17:33:15 +0400 [thread overview]
Message-ID: <4BFFC61B.7050402@mvista.com> (raw)
In-Reply-To: <4BFF541F.2080209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hello.
Wan ZongShun wrote:
> Dear all,
> Use the resource_size function instead of manually calculating the
> resource size. This reduces the chance of introducing off-by-one
> errors.
> In addition, to use __devinit and __devexit is good too.
"Good" isn't a good justification I think.
Also, this just asks to be put into two patches instead of one as
the patch does two completely different things.
> Signed-off-by:Wan ZongShun<mcuos.com-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
WBR, Sergei
prev parent reply other threads:[~2010-05-28 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 5:26 [PATCH] ALSA/davinci: Use the resource_size , __devinit and __devexit Wan ZongShun
[not found] ` <4BFF541F.2080209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-05-28 13:33 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFFC61B.7050402@mvista.com \
--to=sshtylyov-igf4poytycdqt0dzr+alfa@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=mcuos.com-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.