All of lore.kernel.org
 help / color / mirror / Atom feed
From: mkl@pengutronix.de (Marc Kleine-Budde)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] mx35: add flexcan devices
Date: Fri, 28 May 2010 15:45:18 +0200	[thread overview]
Message-ID: <4BFFC8EE.8060501@pengutronix.de> (raw)
In-Reply-To: <20100528133424.GA2001@bluebox.local>

Hans J. Koch wrote:
> On Fri, May 28, 2010 at 01:42:18PM +0200, Marc Kleine-Budde wrote:
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>>  arch/arm/mach-mx3/devices.c |   40 ++++++++++++++++++++++++++++++++++++++++
>>  arch/arm/mach-mx3/devices.h |    2 ++
>>  2 files changed, 42 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-mx3/devices.c b/arch/arm/mach-mx3/devices.c
>> index db7acd6..0e1e20b 100644
>> --- a/arch/arm/mach-mx3/devices.c
>> +++ b/arch/arm/mach-mx3/devices.c
>> @@ -127,6 +127,46 @@ struct platform_device mxc_uart_device4 = {
>>  };
>>  #endif /* CONFIG_ARCH_MX31 */
>>  
>> +#ifdef CONFIG_ARCH_MX35
>> +static struct resource mxc_can_1_resources[] = {
>> +	{
>> +		.start	= 0x53fe4000,
>> +		.end	= 0x53fe7fff,
>> +		.flags	= IORESOURCE_MEM,
>> +	}, {
>> +		.start	= 43,
>> +		.end	= 43,
>> +		.flags	= IORESOURCE_IRQ,
>> +	}
>> +};
>> +
>> +struct platform_device mxc_can_device0 = {
>> +	.name = "flexcan",
> 
> Did you also post the flexcan driver itself somewhere? I've got such a device
> on my desk right now, and would be willing to test that. I've made some tests
> with Sascha's old version, but it's not really satisfying...

It's not yet posted, I'm currently restructuring the driver with regards
to the set_bittiming and control mode discussion on the socketcan ML.

cheers, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100528/a45970b7/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Hans J. Koch" <hjk@linutronix.de>
Cc: sha@pengutronix.de, Sascha Hauer <kernel@pengutronix.de>,
	Russell King <linux@arm.linux.org.uk>,
	Vladimir Zapolskiy <vzapolskiy@gmail.com>,
	Juergen Beisert <j.beisert@pengutronix.de>,
	Alberto Panizzo <maramaopercheseimorto@gmail.com>,
	Wolfram Sang <w.sang@pengutronix.de>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Valentin Longchamp <valentin.longchamp@epfl.ch>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mx35: add flexcan devices
Date: Fri, 28 May 2010 15:45:18 +0200	[thread overview]
Message-ID: <4BFFC8EE.8060501@pengutronix.de> (raw)
In-Reply-To: <20100528133424.GA2001@bluebox.local>

[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]

Hans J. Koch wrote:
> On Fri, May 28, 2010 at 01:42:18PM +0200, Marc Kleine-Budde wrote:
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>>  arch/arm/mach-mx3/devices.c |   40 ++++++++++++++++++++++++++++++++++++++++
>>  arch/arm/mach-mx3/devices.h |    2 ++
>>  2 files changed, 42 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-mx3/devices.c b/arch/arm/mach-mx3/devices.c
>> index db7acd6..0e1e20b 100644
>> --- a/arch/arm/mach-mx3/devices.c
>> +++ b/arch/arm/mach-mx3/devices.c
>> @@ -127,6 +127,46 @@ struct platform_device mxc_uart_device4 = {
>>  };
>>  #endif /* CONFIG_ARCH_MX31 */
>>  
>> +#ifdef CONFIG_ARCH_MX35
>> +static struct resource mxc_can_1_resources[] = {
>> +	{
>> +		.start	= 0x53fe4000,
>> +		.end	= 0x53fe7fff,
>> +		.flags	= IORESOURCE_MEM,
>> +	}, {
>> +		.start	= 43,
>> +		.end	= 43,
>> +		.flags	= IORESOURCE_IRQ,
>> +	}
>> +};
>> +
>> +struct platform_device mxc_can_device0 = {
>> +	.name = "flexcan",
> 
> Did you also post the flexcan driver itself somewhere? I've got such a device
> on my desk right now, and would be willing to test that. I've made some tests
> with Sascha's old version, but it's not really satisfying...

It's not yet posted, I'm currently restructuring the driver with regards
to the set_bittiming and control mode discussion on the socketcan ML.

cheers, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2010-05-28 13:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1275046938-8465-1-git-send-email-mkl@pengutronix.de>
2010-05-28 11:42 ` [PATCH 1/4] mx25: flexcan clock support Marc Kleine-Budde
2010-05-28 11:42   ` Marc Kleine-Budde
2010-05-28 11:42 ` [PATCH 2/4] mx25: Add flexcan devices Marc Kleine-Budde
2010-05-28 11:42   ` Marc Kleine-Budde
2010-05-28 11:42 ` [PATCH 3/4] mx35: adjust flexcan clock definition Marc Kleine-Budde
2010-05-28 11:42   ` Marc Kleine-Budde
2010-05-28 11:42 ` [PATCH 4/4] mx35: add flexcan devices Marc Kleine-Budde
2010-05-28 11:42   ` Marc Kleine-Budde
2010-05-28 13:34   ` Hans J. Koch
2010-05-28 13:34     ` Hans J. Koch
2010-05-28 13:45     ` Marc Kleine-Budde [this message]
2010-05-28 13:45       ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BFFC8EE.8060501@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.