All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Farina <sidhayn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
	"Joker Joker" <jokesareonyou@gmail.com>,
	linux-wireless@vger.kernel.org
Subject: Re: Path for fixed channel issue in aircrack-ng suite
Date: Fri, 28 May 2010 14:28:56 -0400	[thread overview]
Message-ID: <4C000B68.9000305@gmail.com> (raw)
In-Reply-To: <1274860275.3658.0.camel@jlt3.sipsolutions.net>

Johannes Berg wrote:
> On Wed, 2010-05-26 at 00:54 +0200, Gábor Stefanik wrote:
>
>   
>>>> -       if (wdev)
>>>> -               wdev->channel = chan;
>>>> +       wdev = old_wdev;
>>>> +       wdev->channel = chan;
>>>>         
>>> NACK. That will crash when there really is no interface being passed in.
>>>
>>> johannes
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>>>       
>> Well, the original version already dereferences wdev in "if
>> (wdev->iftype...", so the crash is nothing new if it exists.
>>     
>
> It has also been fixed since.
>
>   
Is someone porting this fix into wireless-testing and stable or does 
that still need to be done? Fixed channel of -1 is sort of an issue for 
using monitor mode....

Thanks,
Rick
> johannes
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>   


  parent reply	other threads:[~2010-05-28 18:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-25  5:07 Path for fixed channel issue in aircrack-ng suite Joker Joker
2010-05-25  8:11 ` Johannes Berg
2010-05-25 22:54   ` Gábor Stefanik
2010-05-26  7:51     ` Johannes Berg
2010-05-27  3:51       ` Richard Farina
2010-05-28 18:28       ` Richard Farina [this message]
2010-06-01 18:28         ` Path for fixed channel issue in aircrack-ng suite [V2] Maxim Levitsky
2010-06-01 18:36           ` Richard Farina
2010-06-01 19:19           ` Johannes Berg
2010-06-01 19:50             ` Richard Farina
2010-06-01 20:19               ` Johannes Berg
2010-06-01 21:53                 ` Thomas d'Otreppe
2010-06-01 19:53             ` Maxim Levitsky
2010-06-01 20:06               ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C000B68.9000305@gmail.com \
    --to=sidhayn@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=jokesareonyou@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netrolller.3d@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.