From: Richard Farina <sidhayn@gmail.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
"Gábor Stefanik" <netrolller.3d@gmail.com>,
"Joker Joker" <jokesareonyou@gmail.com>,
linux-wireless@vger.kernel.org, mister_x@aircrack-ng.org
Subject: Re: Path for fixed channel issue in aircrack-ng suite [V2]
Date: Tue, 01 Jun 2010 14:36:12 -0400 [thread overview]
Message-ID: <4C05531C.7000506@gmail.com> (raw)
In-Reply-To: <1275416907.3778.11.camel@maxim-laptop>
Maxim Levitsky wrote:
> While debugging recent wireless problems, I gave the aircrack suite a
> shot, and found this thread.
>
>
Thanks Maxim!
> How about this patch to fix this issue:
>
>
I will definitely find some testers, the problem is that I have been
unable to reliably reproduce the "channel -1". Since I don't know the
exact conditions this happens under the best I can do is have a few
people test it and make sure no one sees the error.
Mister_X, how does this look to you? I assume you are familiar with the
issue.
Thanks,
Rick Farina
> commit fffd6e63ea75850dafbf2ccfb38a4189f43c0282
> Author: Maxim Levitsky <maximlevitsky@gmail.com>
> Date: Tue Jun 1 15:43:21 2010 +0300
>
> wireless: allow to retrieve the channel set on monitor interface
>
> This will allow to preserve compatibility with userspace
>
> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
>
> diff --git a/net/wireless/chan.c b/net/wireless/chan.c
> index b01a6f6..09d979b 100644
> --- a/net/wireless/chan.c
> +++ b/net/wireless/chan.c
> @@ -49,9 +49,12 @@ int cfg80211_set_freq(struct cfg80211_registered_device *rdev,
> {
> struct ieee80211_channel *chan;
> int result;
> + struct wireless_dev *mon_dev = NULL;
>
> - if (wdev && wdev->iftype == NL80211_IFTYPE_MONITOR)
> + if (wdev && wdev->iftype == NL80211_IFTYPE_MONITOR) {
> + mon_dev = wdev;
> wdev = NULL;
> + }
>
> if (wdev) {
> ASSERT_WDEV_LOCK(wdev);
> @@ -76,5 +79,8 @@ int cfg80211_set_freq(struct cfg80211_registered_device *rdev,
> if (wdev)
> wdev->channel = chan;
>
> + if (mon_dev)
> + mon_dev->channel = chan;
> +
> return 0;
> }
>
>
>
>
next prev parent reply other threads:[~2010-06-01 18:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 5:07 Path for fixed channel issue in aircrack-ng suite Joker Joker
2010-05-25 8:11 ` Johannes Berg
2010-05-25 22:54 ` Gábor Stefanik
2010-05-26 7:51 ` Johannes Berg
2010-05-27 3:51 ` Richard Farina
2010-05-28 18:28 ` Richard Farina
2010-06-01 18:28 ` Path for fixed channel issue in aircrack-ng suite [V2] Maxim Levitsky
2010-06-01 18:36 ` Richard Farina [this message]
2010-06-01 19:19 ` Johannes Berg
2010-06-01 19:50 ` Richard Farina
2010-06-01 20:19 ` Johannes Berg
2010-06-01 21:53 ` Thomas d'Otreppe
2010-06-01 19:53 ` Maxim Levitsky
2010-06-01 20:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C05531C.7000506@gmail.com \
--to=sidhayn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=jokesareonyou@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=mister_x@aircrack-ng.org \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.