From: Jiri Slaby <jirislaby@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Richard Zidlicky <rz@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: schedule inside spin_lock_irqsave?
Date: Sun, 30 May 2010 17:32:15 +0200 [thread overview]
Message-ID: <4C0284FF.4080707@gmail.com> (raw)
In-Reply-To: <4C028336.8030704@gmail.com>
On 05/30/2010 05:24 PM, Jiri Slaby wrote:
> struct smscore_buffer_t *get_entry(void)
> {
> struct smscore_buffer_t *cb = NULL;
> spin_lock_irqsave(&coredev->bufferslock, flags);
> if (!list_empty(&coredev->buffers)) {
> cb = (struct smscore_buffer_t *) coredev->buffers.next;
Looking at the smscore_buffer_t definition, this is really ugly since it
relies on entry being the first in the structure. It should be
list_first_entry(&coredev->buffers, ...) instead, cast-less.
> list_del(&cb->entry);
> }
> spin_unlock_irqrestore(&coredev->bufferslock, flags);
> return cb;
> }
--
js
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: unlisted-recipients:; (no To-header on input)@bombadil.infradead.org
Cc: Richard Zidlicky <rz@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: schedule inside spin_lock_irqsave?
Date: Sun, 30 May 2010 17:32:15 +0200 [thread overview]
Message-ID: <4C0284FF.4080707@gmail.com> (raw)
In-Reply-To: <4C028336.8030704@gmail.com>
On 05/30/2010 05:24 PM, Jiri Slaby wrote:
> struct smscore_buffer_t *get_entry(void)
> {
> struct smscore_buffer_t *cb = NULL;
> spin_lock_irqsave(&coredev->bufferslock, flags);
> if (!list_empty(&coredev->buffers)) {
> cb = (struct smscore_buffer_t *) coredev->buffers.next;
Looking at the smscore_buffer_t definition, this is really ugly since it
relies on entry being the first in the structure. It should be
list_first_entry(&coredev->buffers, ...) instead, cast-less.
> list_del(&cb->entry);
> }
> spin_unlock_irqrestore(&coredev->bufferslock, flags);
> return cb;
> }
--
js
next prev parent reply other threads:[~2010-05-30 15:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 14:52 schedule inside spin_lock_irqsave? Richard Zidlicky
2010-05-30 15:24 ` Jiri Slaby
2010-05-30 15:32 ` Jiri Slaby [this message]
2010-05-30 15:32 ` Jiri Slaby
2010-06-01 17:17 ` Richard Zidlicky
2010-06-06 12:43 ` [PATCH 2.6.34] schedule inside spin_lock_irqsave Richard Zidlicky
2010-06-06 17:51 ` Jiri Slaby
2010-06-07 13:00 ` Richard Zidlicky
2010-07-06 12:40 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0284FF.4080707@gmail.com \
--to=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rz@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.