[PATCH]libxl: enable remote shutdown for pure hvm domain.

[PATCH]libxl: enable remote shutdown for pure hvm domain.

[Zhigang Wang]

[-- Attachment #1: Type: text/plain, Size: 69 bytes --]

Hi Stefano,

Is this a typo or intended to be so?

Thanks,

Zhigang


[-- Attachment #2: xen-libxl-fix-domain-shutdown-hvm.patch --]
[-- Type: text/plain, Size: 666 bytes --]

libxl: enable remote shutdown for pure hvm domain.

Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>

diff -r 96917cf25bf3 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c	Fri May 28 10:54:07 2010 +0100
+++ b/tools/libxl/libxl.c	Mon May 31 17:05:42 2010 +0800
@@ -550,7 +550,7 @@
     shutdown_path = libxl_sprintf(ctx, "%s/control/shutdown", dom_path);
 
     xs_write(ctx->xsh, XBT_NULL, shutdown_path, req_table[req], strlen(req_table[req]));
-    if (/* hvm */ 0) {
+    if (is_hvm(ctx, domid)) {
         unsigned long acpi_s_state = 0;
         unsigned long pvdriver = 0;
         xc_get_hvm_param(ctx->xch, domid, HVM_PARAM_ACPI_S_STATE, &acpi_s_state);

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH]libxl: enable remote shutdown for pure hvm domain.

[Yang Hongyang]

Hi,

On 05/31/2010 05:13 PM, Zhigang Wang wrote:
> Hi Stefano,
> 
> Is this a typo or intended to be so?

Please refer to this thread's discussion.

http://lists.xensource.com/archives/html/xen-devel/2010-05/msg00361.html

> 
> Thanks,
> 
> Zhigang
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel


-- 
Regards
Yang Hongyang

Re: [PATCH]libxl: enable remote shutdown for pure hvm domain. - withdraw

[Zhigang Wang]

On 05/31/2010 05:31 PM, Yang Hongyang wrote:
> Hi,
> 
> On 05/31/2010 05:13 PM, Zhigang Wang wrote:
>> Hi Stefano,
>>
>> Is this a typo or intended to be so?
> 
> Please refer to this thread's discussion.
> 
> http://lists.xensource.com/archives/html/xen-devel/2010-05/msg00361.html
> 

Thanks Hongyang.

I'll withdraw this patch and try to help Gihan Munasinghe to improve his patch.

Zhigang

Re: [PATCH]libxl: enable remote shutdown for pure hvm domain. - withdraw

[Stefano Stabellini]

On Mon, 31 May 2010, Zhigang Wang wrote:
> On 05/31/2010 05:31 PM, Yang Hongyang wrote:
> > Hi,
> > 
> > On 05/31/2010 05:13 PM, Zhigang Wang wrote:
> >> Hi Stefano,
> >>
> >> Is this a typo or intended to be so?
> > 
> > Please refer to this thread's discussion.
> > 
> > http://lists.xensource.com/archives/html/xen-devel/2010-05/msg00361.html
> > 
> 
> Thanks Hongyang.
> 
> I'll withdraw this patch and try to help Gihan Munasinghe to improve his patch.
> 

Yeah, that would be ideal.
However we know that the code to detect that PV drivers are running in
the guest is correct because we are using it already in the
suspend/resume case (libxl_dom.c:core_suspend_callback).

Re: [PATCH]libxl: enable remote shutdown for pure hvm domain.

[Stefano Stabellini]

On Mon, 31 May 2010, Zhigang Wang wrote:
> Hi Stefano,
> 
> Is this a typo or intended to be so?

I think I disabled it at the time because I couldn't test it so I wasn't
sure it was working.
You can safely enable it now.
Thanks,

Stefano