ARM: SAMSUNG: question about cfg_eint field of struct s3c_gpio

All of lore.kernel.org
 help / color / mirror / Atom feed

* ARM: SAMSUNG: question about cfg_eint field of struct s3c_gpio_cfg
@ 2010-05-31 11:22 Joonyoung Shim
  2010-06-03  0:51 ` Ben Dooks
  0 siblings, 1 reply; 2+ messages in thread
From: Joonyoung Shim @ 2010-05-31 11:22 UTC (permalink / raw)
  To: ben-linux; +Cc: linux-samsung-soc

Hi,

There is cfg_eint field in struct s3c_gpio_cfg at 
arch/arm/plat-samsung/include/plat/gpio-cfg.h. I don't know the usage of 
cfg_eint. It isn't used anywhere or just assigned. Does it need really?

struct s3c_gpio_cfg {
	unsigned int	cfg_eint;

	s3c_gpio_pull_t	(*get_pull)(struct s3c_gpio_chip *chip, unsigned offs);
	int		(*set_pull)(struct s3c_gpio_chip *chip, unsigned offs,
				    s3c_gpio_pull_t pull);

	unsigned (*get_config)(struct s3c_gpio_chip *chip, unsigned offs);
	int	 (*set_config)(struct s3c_gpio_chip *chip, unsigned offs,
			       unsigned config);
};

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: ARM: SAMSUNG: question about cfg_eint field of struct s3c_gpio_cfg
  2010-05-31 11:22 ARM: SAMSUNG: question about cfg_eint field of struct s3c_gpio_cfg Joonyoung Shim
@ 2010-06-03  0:51 ` Ben Dooks
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Dooks @ 2010-06-03  0:51 UTC (permalink / raw)
  To: Joonyoung Shim; +Cc: ben-linux, linux-samsung-soc

On Mon, May 31, 2010 at 08:22:12PM +0900, Joonyoung Shim wrote:
> Hi,
> 
> There is cfg_eint field in struct s3c_gpio_cfg at 
> arch/arm/plat-samsung/include/plat/gpio-cfg.h. I don't know the usage of 
> cfg_eint. It isn't used anywhere or just assigned. Does it need really?

It was there for the interrupt code to configure the external-interrupt
information, but it was never used. It probably wants deleting if we can't
re-use it.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-06-03  0:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-31 11:22 ARM: SAMSUNG: question about cfg_eint field of struct s3c_gpio_cfg Joonyoung Shim
2010-06-03  0:51 ` Ben Dooks

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.