All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maurus Cuelenaere <mcuelenaere@gmail.com>
To: linux-samsung-soc@vger.kernel.org
Cc: ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: S3C64XX: Stop and flush requests on freeing
Date: Mon, 31 May 2010 13:58:34 +0200	[thread overview]
Message-ID: <4C03A46A.2090403@gmail.com> (raw)
In-Reply-To: <cover.1275306279.git.mcuelenaere@gmail.com>

When a DMA channel is freed, its pending requests should be flushed and the
channel should be halted. This patch ensures that happens.

Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
---
 arch/arm/mach-s3c64xx/dma.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/dma.c b/arch/arm/mach-s3c64xx/dma.c
index 8c9946f..193b07f 100644
--- a/arch/arm/mach-s3c64xx/dma.c
+++ b/arch/arm/mach-s3c64xx/dma.c
@@ -560,7 +560,8 @@ int s3c2410_dma_free(unsigned int channel, struct s3c2410_dma_client *client)
 		       channel, chan->client, client);
 	}
 
-	/* sort out stopping and freeing the channel */
+	s3c64xx_dma_flush(chan);
+	s3c64xx_dma_stop(chan);
 
 	chan->client = NULL;
 	chan->in_use = 0;
-- 
1.7.1

WARNING: multiple messages have this Message-ID (diff)
From: mcuelenaere@gmail.com (Maurus Cuelenaere)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: S3C64XX: Stop and flush requests on freeing
Date: Mon, 31 May 2010 13:58:34 +0200	[thread overview]
Message-ID: <4C03A46A.2090403@gmail.com> (raw)
In-Reply-To: <cover.1275306279.git.mcuelenaere@gmail.com>

When a DMA channel is freed, its pending requests should be flushed and the
channel should be halted. This patch ensures that happens.

Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
---
 arch/arm/mach-s3c64xx/dma.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/dma.c b/arch/arm/mach-s3c64xx/dma.c
index 8c9946f..193b07f 100644
--- a/arch/arm/mach-s3c64xx/dma.c
+++ b/arch/arm/mach-s3c64xx/dma.c
@@ -560,7 +560,8 @@ int s3c2410_dma_free(unsigned int channel, struct s3c2410_dma_client *client)
 		       channel, chan->client, client);
 	}
 
-	/* sort out stopping and freeing the channel */
+	s3c64xx_dma_flush(chan);
+	s3c64xx_dma_stop(chan);
 
 	chan->client = NULL;
 	chan->in_use = 0;
-- 
1.7.1

  parent reply	other threads:[~2010-05-31 11:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1275306279.git.mcuelenaere@gmail.com>
2010-05-31 11:58 ` [PATCH 1/3] ARM: S3C64XX: Add SDMA clocks Maurus Cuelenaere
2010-05-31 11:58   ` Maurus Cuelenaere
2010-05-31 11:58 ` [PATCH 2/3] ARM: S3C64XX: Add SDMA support to DMA core Maurus Cuelenaere
2010-05-31 11:58   ` Maurus Cuelenaere
2010-05-31 12:16   ` [PATCH 2/3 v2] " Maurus Cuelenaere
2010-05-31 12:16     ` Maurus Cuelenaere
2010-05-31 11:58 ` Maurus Cuelenaere [this message]
2010-05-31 11:58   ` [PATCH 3/3] ARM: S3C64XX: Stop and flush requests on freeing Maurus Cuelenaere
2010-05-31 11:34 Maurus Cuelenaere
2010-08-15 13:08 ` Maurus Cuelenaere
2010-08-15 13:28 ` Jassi Brar
2010-08-15 13:28   ` Jassi Brar
2010-08-15 13:36   ` Jassi Brar
2010-08-15 13:36     ` Jassi Brar
2010-08-15 13:42     ` Maurus Cuelenaere
2010-08-15 13:42       ` Maurus Cuelenaere

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C03A46A.2090403@gmail.com \
    --to=mcuelenaere@gmail.com \
    --cc=ben-linux@fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.