From: Jiri Slaby <jirislaby@gmail.com>
To: Spyros Papageorgiou <spyros.papageorgiou@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org, ossama.othman@intel.com,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Drivers: Stagins: memrar: cleanup
Date: Mon, 31 May 2010 17:37:14 +0000 [thread overview]
Message-ID: <4C03F3CA.6070809@gmail.com> (raw)
In-Reply-To: <4C03CFED.2030101@gmail.com>
On 05/31/2010 05:04 PM, Spyros Papageorgiou wrote:
> From:Spyros Papageorgiou <spyros.papageorgiou@gmai.com>
>
> Removed an unneeded struct specifier in function call.
>
> Signed-off-by: Spyros Papageorgiou <spyros.papageorgiou@gmai.com>
> ---
> drivers/staging/memrar/memrar_allocator.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/memrar/memrar_allocator.c b/drivers/staging/memrar/memrar_allocator.c
> index a4f8c58..db37c6a 100644
> --- a/drivers/staging/memrar/memrar_allocator.c
> +++ b/drivers/staging/memrar/memrar_allocator.c
> @@ -276,7 +276,7 @@ long memrar_allocator_free(struct memrar_allocator *allocator,
>
> struct memrar_address_range * const chunk > &list_entry(pos,
> - struct memrar_address_ranges,
> + memrar_address_ranges,
> list)->range;
It is not a function call, it's a macro. Did you try to compile this?
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Spyros Papageorgiou <spyros.papageorgiou@gmail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org, ossama.othman@intel.com,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Drivers: Stagins: memrar: cleanup
Date: Mon, 31 May 2010 19:37:14 +0200 [thread overview]
Message-ID: <4C03F3CA.6070809@gmail.com> (raw)
In-Reply-To: <4C03CFED.2030101@gmail.com>
On 05/31/2010 05:04 PM, Spyros Papageorgiou wrote:
> From:Spyros Papageorgiou <spyros.papageorgiou@gmai.com>
>
> Removed an unneeded struct specifier in function call.
>
> Signed-off-by: Spyros Papageorgiou <spyros.papageorgiou@gmai.com>
> ---
> drivers/staging/memrar/memrar_allocator.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/memrar/memrar_allocator.c b/drivers/staging/memrar/memrar_allocator.c
> index a4f8c58..db37c6a 100644
> --- a/drivers/staging/memrar/memrar_allocator.c
> +++ b/drivers/staging/memrar/memrar_allocator.c
> @@ -276,7 +276,7 @@ long memrar_allocator_free(struct memrar_allocator *allocator,
>
> struct memrar_address_range * const chunk =
> &list_entry(pos,
> - struct memrar_address_ranges,
> + memrar_address_ranges,
> list)->range;
It is not a function call, it's a macro. Did you try to compile this?
next prev parent reply other threads:[~2010-05-31 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 15:04 [PATCH] Drivers: Stagins: memrar: cleanup Spyros Papageorgiou
2010-05-31 15:04 ` Spyros Papageorgiou
2010-05-31 17:37 ` Jiri Slaby [this message]
2010-05-31 17:37 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C03F3CA.6070809@gmail.com \
--to=jirislaby@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ossama.othman@intel.com \
--cc=spyros.papageorgiou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.