From: walter harms <wharms@bfs.de>
To: Dan Carpenter <error27@gmail.com>
Cc: Sjur Braendeland <sjur.brandeland@stericsson.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] caif: remove unneeded variable from caif_net_open()
Date: Tue, 01 Jun 2010 07:27:02 +0000 [thread overview]
Message-ID: <4C04B646.9080506@bfs.de> (raw)
In-Reply-To: <20100601070855.GD5483@bicker>
Dan Carpenter schrieb:
> We don't use the "ser" variable so I've removed it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
> index 09257ca..f30a6a0 100644
> --- a/drivers/net/caif/caif_serial.c
> +++ b/drivers/net/caif/caif_serial.c
> @@ -410,8 +410,6 @@ static void caifdev_setup(struct net_device *dev)
>
> static int caif_net_open(struct net_device *dev)
> {
> - struct ser_device *ser;
> - ser = netdev_priv(dev);
> netif_wake_queue(dev);
> return 0;
> }
what makes caif_net_open() obsolet ?
re,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Dan Carpenter <error27@gmail.com>
Cc: Sjur Braendeland <sjur.brandeland@stericsson.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] caif: remove unneeded variable from caif_net_open()
Date: Tue, 01 Jun 2010 09:27:02 +0200 [thread overview]
Message-ID: <4C04B646.9080506@bfs.de> (raw)
In-Reply-To: <20100601070855.GD5483@bicker>
Dan Carpenter schrieb:
> We don't use the "ser" variable so I've removed it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
> index 09257ca..f30a6a0 100644
> --- a/drivers/net/caif/caif_serial.c
> +++ b/drivers/net/caif/caif_serial.c
> @@ -410,8 +410,6 @@ static void caifdev_setup(struct net_device *dev)
>
> static int caif_net_open(struct net_device *dev)
> {
> - struct ser_device *ser;
> - ser = netdev_priv(dev);
> netif_wake_queue(dev);
> return 0;
> }
what makes caif_net_open() obsolet ?
re,
wh
next prev parent reply other threads:[~2010-06-01 7:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 7:08 [patch 1/2] caif: remove unneeded variable from caif_net_open() Dan Carpenter
2010-06-01 7:08 ` Dan Carpenter
2010-06-01 7:19 ` Sjur BRENDELAND
2010-06-01 7:19 ` Sjur BRENDELAND
2010-06-01 7:27 ` walter harms [this message]
2010-06-01 7:27 ` walter harms
2010-06-01 7:45 ` Dan Carpenter
2010-06-01 7:45 ` Dan Carpenter
2010-06-02 12:16 ` David Miller
2010-06-02 12:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C04B646.9080506@bfs.de \
--to=wharms@bfs.de \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.