Re: [PATCH 0/9] OMAP: DMTIMER: Convert platform driver so as to make use of hwmod + omap device framework for OMAP2 PLUS

[Benoit <b-cousson@ti.com>]

On 6/4/2010 12:20 AM, Kevin Hilman wrote:
> Benoit Cousson<b-cousson@ti.com>  writes:
>
>> On 5/29/2010 4:37 PM, Gopinath, Thara wrote:
>>> This patch series converts the OMAP Dual Mode Timer into a
>>> platform driver. This involves using of hwmod structures and
>>> omap_device layer for OMAP2/3/4 dmtimers and generic
>>> linux platform device layer for OMAP1.
>>>
>>> As a result of this patch series the dmtimer platform driver
>>> resides in arch/arm/plat-omap directory and arch specific
>>> implementations and device registerations reside in
>>> arch/arm/mach-omap1 and arch/arm/mach-omap2 for OMAP1
>>> and OMAP2 PLUS respectively.
>>
>> Hi Thara,
>>
>> The Dual timer terminology is not used anymore since 2420.
>> It was replaced by gptimer and will be simplified going forward
>> using timer. This IP is almost the same since 1610, but will have 3
>> different names.
>> It might be the good opportunity to align the names?
>
> If we were to align the names, what should be the "aligned" name?
> gptimer or timer?  I tend to prefer gptimer as 'timer' is rather
> ambiguous in this context.

Arrrgs, too late... After many discussions we agreed on 'timer' with HW 
folks. Neither dmtimer not gptimer bring any useful information. Timer 
that are not regular timers will have some prefix / postfix like wd_ for 
the watchdog. And synctimer not being a timer at all will then be 
renamed counter.
Why do you think 'timer' is ambiguous?

Benoit

> For now, we could leave the names of all the functions and structs as
> 'dm_timer', but at least this serious could name the new files and the
> platform devices with the new name.  At the end of the series, one
> final patch to s/dm_timer/new_beautiful_name/ would be an easy patch.
>
> Kevin