Re: [PATCH 0/9] OMAP: DMTIMER: Convert platform driver so as to make use of hwmod + omap device framework for OMAP2 PLUS

[Kevin Hilman <khilman@deeprootsystems.com>]

Benoit <b-cousson@ti.com> writes:

> On 6/4/2010 12:20 AM, Kevin Hilman wrote:
>> Benoit Cousson<b-cousson@ti.com>  writes:
>>
>>> On 5/29/2010 4:37 PM, Gopinath, Thara wrote:
>>>> This patch series converts the OMAP Dual Mode Timer into a
>>>> platform driver. This involves using of hwmod structures and
>>>> omap_device layer for OMAP2/3/4 dmtimers and generic
>>>> linux platform device layer for OMAP1.
>>>>
>>>> As a result of this patch series the dmtimer platform driver
>>>> resides in arch/arm/plat-omap directory and arch specific
>>>> implementations and device registerations reside in
>>>> arch/arm/mach-omap1 and arch/arm/mach-omap2 for OMAP1
>>>> and OMAP2 PLUS respectively.
>>>
>>> Hi Thara,
>>>
>>> The Dual timer terminology is not used anymore since 2420.
>>> It was replaced by gptimer and will be simplified going forward
>>> using timer. This IP is almost the same since 1610, but will have 3
>>> different names.
>>> It might be the good opportunity to align the names?
>>
>> If we were to align the names, what should be the "aligned" name?
>> gptimer or timer?  I tend to prefer gptimer as 'timer' is rather
>> ambiguous in this context.
>
> Arrrgs, too late... After many discussions we agreed on 'timer' with
> HW folks. Neither dmtimer not gptimer bring any useful
> information. Timer that are not regular timers will have some prefix /
> postfix like wd_ for the watchdog. And synctimer not being a timer at
> all will then be renamed counter.
> Why do you think 'timer' is ambiguous?

Maybe vague is better than ambiguous.  Timer is an all-encompasing
term for all the things you mentioned above, as well as ARM-generic
timers presumably coming down the road.

I guess since this is in OMAP-specific code, 'timer' is fine, but it
doesn't feel right.  Maybe we need to call it 'omap_timer'.?

Kevin