All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Colin Tuckley <colin.tuckley@arm.com>
Cc: linux-ide@vger.kernel.org,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Robin Randhawa <Robin.Randhawa@arm.com>
Subject: Re: ARM: Fix kernel panic caused by unaligned access in sata_sil24
Date: Fri, 04 Jun 2010 15:23:50 +0200	[thread overview]
Message-ID: <4C08FE66.9000306@kernel.org> (raw)
In-Reply-To: <4C08FE27.1050109@kernel.org>

On 06/04/2010 03:22 PM, Tejun Heo wrote:
> On 06/04/2010 02:37 PM, Colin Tuckley wrote:
>> From: Colin Tuckley <colin.tuckley@arm.com>
>>
>> Subject: ARM: Fix kernel panic caused by unaligned access in sata_sil24
>>
>> The sata_sil24 driver has six 16-bit registers that are initialised with
>> 32-bit writes. This cause a kernel panic on ARM due to the unaligned
>> accesses which result.
>>
>> This patch changes the accesses to the correct 16-bit ones.
>>
>> Signed-off-by: Colin Tuckley <colin.tuckley@arm.com>
> 
> Acked-by: Tejun Heo <tj@kernel.org>

Oh, but please add Jeff Garzik and add sata_sil24: prefix to the
subject.

Thanks.

-- 
tejun

      reply	other threads:[~2010-06-04 13:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <000301cb03e2$bf0020e0$3d0062a0$@tuckley@arm.com>
2010-06-04 13:22 ` ARM: Fix kernel panic caused by unaligned access in sata_sil24 Tejun Heo
2010-06-04 13:23   ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C08FE66.9000306@kernel.org \
    --to=tj@kernel.org \
    --cc=Catalin.Marinas@arm.com \
    --cc=Robin.Randhawa@arm.com \
    --cc=colin.tuckley@arm.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.