From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tsec: fix the return value for tsec_eth_init()
Date: Fri, 04 Jun 2010 16:01:09 -0500 [thread overview]
Message-ID: <4C096995.4090101@freescale.com> (raw)
In-Reply-To: <254C866E-B460-47D7-8CCC-9C8F200189C1@freescale.com>
Andy Fleming wrote:
> The old way continued even if one of the tsecs failed to initialize. Let's preserve the original behavior in that sense:
>
> for (i = 0; i < num; i++) {
> ret = tsec_initialize(bis, &tsecs[i]);
> if (ret >= 0)
> count++;
> }
This code has multiple levels to it. board_eth_init() calls
tsec_eth_init(), pci_eth_init(), and maybe some other functions.
tsec_eth_init() calls tsec_initialize(). tsec_initialize() calls
init_phy(). Are we always going to ignore an error return code? Why don't
we just eliminate the possibility of returning a negative number at all levels?
next prev parent reply other threads:[~2010-06-04 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 20:50 [U-Boot] [PATCH] tsec: fix the return value for tsec_eth_init() Timur Tabi
2010-06-04 20:57 ` Andy Fleming
2010-06-04 21:01 ` Timur Tabi [this message]
2010-06-04 21:39 ` Andy Fleming
2010-06-04 21:42 ` Timur Tabi
2010-06-04 21:48 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C096995.4090101@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.