From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tsec: fix the return value for tsec_eth_init()
Date: Fri, 04 Jun 2010 16:42:05 -0500 [thread overview]
Message-ID: <4C09732D.1050608@freescale.com> (raw)
In-Reply-To: <FBFF9378-18C0-425D-896D-477E8673372B@freescale.com>
Andy Fleming wrote:
> You just noted that tsec_eth_init should return the number of tsecs
> initialized successfully. Therefore, the callers can check that number,
> and respond accordingly. tsec_initialize() can report the error. If we
> want more elaborate error handling, we can devise something. But with
> the new scheme, an error in one tsec (like a riser card not being plugged
> in) will cause all of the tsecs to not be initialized, which seems
> silly.
Ok, so the rule is: a function which initializes one interface can return an
error <0, but a function which initializes multiple interfaces should not.
V2 coming right up.
next prev parent reply other threads:[~2010-06-04 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 20:50 [U-Boot] [PATCH] tsec: fix the return value for tsec_eth_init() Timur Tabi
2010-06-04 20:57 ` Andy Fleming
2010-06-04 21:01 ` Timur Tabi
2010-06-04 21:39 ` Andy Fleming
2010-06-04 21:42 ` Timur Tabi [this message]
2010-06-04 21:48 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C09732D.1050608@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.