All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reinhard Meyer (-VC) <reinhard.meyer@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] add support for EMK TOP7000 CPU module
Date: Sun, 06 Jun 2010 13:52:07 +0200	[thread overview]
Message-ID: <4C0B8BE7.7090108@emk-elektronik.de> (raw)
In-Reply-To: <20100606114251.66D2114E867@gemini.denx.de>

Wolfgang Denk schrieb:
> Dear "Reinhard Meyer (-VC)",
> 
> In message <4C0B85D8.4070508@emk-elektronik.de> you wrote:
>> is this patch going to be accepted, or is someone insisting that only
>> my port shall return the number of controllers initialized?
> 
> I don't understand what you mean by "only my port". Ben's comment that
> board_eth_init() is supposed to retrurn the number of  successfully
> initialized controllers has been standard policy for a pretty long
> time, and many boards do so.
> 
> Eventually the boards you compared against are older ones, and have
> not been maintained well, so they misbehave in this regard?
> 
> Best regards,
> 
> Wolfgang Denk
> 

Hello Wolfgang,

Is that documented somewhere? I see that the calling function in net.c
does NOT care about any positive interger result. Will it care sometime
in the future? :)

The second problem is that I cannot seem to undo my previous commit in my
tree, so any changes I do to my source would come out as a second patch.
Would that be accepted?

Or do you know what must be done that GIT will issue a new patch with the
current and the new changes in one patch?

I generate the patches by
<after editing>:
git commit -m <message>
git format-patch origin

what to do to return to <after editing>, do new edits and generate a new,
single patch?

Best Regards, Reinhard

  parent reply	other threads:[~2010-06-06 11:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-05 10:41 [U-Boot] [PATCH] add support for EMK TOP7000 CPU module Reinhard Meyer
2010-06-05 14:41 ` Ben Warren
2010-06-05 18:16   ` Reinhard Meyer
2010-06-06 11:26     ` Reinhard Meyer
2010-06-06 11:42       ` Wolfgang Denk
2010-06-06 11:45         ` Reinhard Meyer
2010-06-06 11:52         ` Reinhard Meyer [this message]
2010-06-06 12:09           ` Reinhard Meyer
2010-06-06 12:16           ` Wolfgang Denk
2010-06-06 13:23           ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0B8BE7.7090108@emk-elektronik.de \
    --to=reinhard.meyer@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.