From: Hans de Goede <hdegoede@redhat.com>
To: huzaifas@redhat.com
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] libv4l1: move VIDIOCCAPTURE to libv4l1
Date: Mon, 07 Jun 2010 09:41:34 +0200 [thread overview]
Message-ID: <4C0CA2AE.5000908@redhat.com> (raw)
In-Reply-To: <1275637214-22089-1-git-send-email-huzaifas@redhat.com>
Hi,
Looks good, applied
Thanks!
Regards,
Hans
On 06/04/2010 09:40 AM, huzaifas@redhat.com wrote:
> From: Huzaifa Sidhpurwala<huzaifas@redhat.com>
>
> move VIDIOCCAPTURE to libv4l1
>
> Signed-of-by: Huzaifa Sidhpurwala<huzaifas@redhat.com>
> ---
> lib/libv4l1/libv4l1.c | 16 ++++++++++++++++
> 1 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/lib/libv4l1/libv4l1.c b/lib/libv4l1/libv4l1.c
> index 579f13b..2981c40 100644
> --- a/lib/libv4l1/libv4l1.c
> +++ b/lib/libv4l1/libv4l1.c
> @@ -967,6 +967,22 @@ int v4l1_ioctl(int fd, unsigned long int request, ...)
>
> break;
> }
> +
> + case VIDIOCCAPTURE: {
> + int *on = arg;
> + enum v4l2_buf_type captype = V4L2_BUF_TYPE_VIDEO_CAPTURE;
> +
> + if (0 == *on) {
> + /* dirty hack time. But v4l1 has no STREAMOFF
> + * equivalent in the API, and this one at
> + * least comes close ... */
> + v4l2_ioctl(fd, VIDIOC_STREAMOFF,&captype);
> + }
> +
> + result = v4l2_ioctl(fd, VIDIOC_OVERLAY, on);
> +
> + break;
> + }
> default:
> /* Pass through libv4l2 for applications which are using v4l2 through
> libv4l1 (this can happen with the v4l1compat.so wrapper preloaded */
prev parent reply other threads:[~2010-06-07 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 7:40 [PATCH] libv4l1: move VIDIOCCAPTURE to libv4l1 huzaifas
2010-06-07 7:41 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0CA2AE.5000908@redhat.com \
--to=hdegoede@redhat.com \
--cc=huzaifas@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.