From: Gerd Hoffmann <kraxel@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.
Date: Tue, 08 Jun 2010 11:26:24 +0200 [thread overview]
Message-ID: <4C0E0CC0.80609@redhat.com> (raw)
In-Reply-To: <201006071712.52267.paul@codesourcery.com>
On 06/07/10 18:12, Paul Brook wrote:
>> Kill nographic timer. Have a global gui_timer instead. Have the gui
>> timer enabled unconditionally. We need a timer running anyway for mmio
>> flush, so the whole have-gui-timer-only-when-needed logic is pretty
>> pointless. It also simplifies displaylisteners coming and going at
>> runtime, we don't need to care about the timer then as it runs anyway.
>
> Linking mmio flushes to the gui is completely bogus. The fact that we're
> doing arbitrary periodic mmio flushes suggests something else is horribly
> broken.
Was added by commit
http://git.qemu.org/qemu.git/commit/?id=62a2744ca09a0b44b8406ea0c430c4c67a2c3231
Patch description makes sense to me. Of course we could have a separate
timer for the mmio flushes instead of re-using the gui timer. But we
would have more wakeups then ...
cheers,
Gerd
next prev parent reply other threads:[~2010-06-08 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 13:44 [Qemu-devel] [PATCH] Fix and simplify gui timer logic Gerd Hoffmann
2010-06-04 13:55 ` [Qemu-devel] " Gerd Hoffmann
2010-06-07 16:12 ` [Qemu-devel] " Paul Brook
2010-06-08 9:26 ` Gerd Hoffmann [this message]
2010-06-08 11:50 ` Paul Brook
2010-06-08 13:18 ` Gerd Hoffmann
2010-06-14 17:06 ` Anthony Liguori
2010-06-14 22:52 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0E0CC0.80609@redhat.com \
--to=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.