From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.
Date: Mon, 14 Jun 2010 23:52:58 +0100 [thread overview]
Message-ID: <201006142352.59262.paul@codesourcery.com> (raw)
In-Reply-To: <4C166187.2080805@codemonkey.ws>
> >> This suggests we are incorrectly coalescing writes, and we should
> >> actually be
> >> notifying qemu when (at least) he first write occurs. If we aren't
> >> outputting
> >> anything we don't want to be waking up periodically just to flush an
> >> empty
> >> MMIO buffer.
> >
> > That is completely unrelated to this patch though. The patch doesn't
> > change mmio flush behaviour at all. And the periodic wakeup was there
> > even before the mmio flush patch was added. Even without gui,
> > although I can't see a obvious reason for it ...
>
> Agreed. Regardless of the periodic mmio flush, having a separate
> nographic timer isn't terribly helpful IMHO.
I guess what I was objecting to is formalising this a "gui_timer" rather than
"arbitrary_polling_hack_timer".
Paul
prev parent reply other threads:[~2010-06-14 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 13:44 [Qemu-devel] [PATCH] Fix and simplify gui timer logic Gerd Hoffmann
2010-06-04 13:55 ` [Qemu-devel] " Gerd Hoffmann
2010-06-07 16:12 ` [Qemu-devel] " Paul Brook
2010-06-08 9:26 ` Gerd Hoffmann
2010-06-08 11:50 ` Paul Brook
2010-06-08 13:18 ` Gerd Hoffmann
2010-06-14 17:06 ` Anthony Liguori
2010-06-14 22:52 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006142352.59262.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.