From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()
Date: Tue, 08 Jun 2010 09:34:28 -0500 [thread overview]
Message-ID: <4C0E54F4.8000006@freescale.com> (raw)
In-Reply-To: <201006080004.05839.vapier@gentoo.org>
Mike Frysinger wrote:
> the documentation currently states that a negative value is permissible and
> thus "int" is correct. as for the code that actually reads the result, that
> is by & large common code, so logic along those lines isnt terribly important.
The conclusion I drew from Andy's comments is that functions which
initialize more than one device should not return a negative value. That
makes sense to me. Perhaps the documentation should be updated to
incorporate this idea?
next prev parent reply other threads:[~2010-06-08 14:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 18:31 [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init() Timur Tabi
2010-06-07 22:49 ` Mike Frysinger
2010-06-07 22:55 ` Timur Tabi
2010-06-08 4:04 ` Mike Frysinger
2010-06-08 14:34 ` Timur Tabi [this message]
2010-06-08 14:42 ` Reinhard Meyer
2010-06-08 14:55 ` Timur Tabi
2010-06-08 19:25 ` Mike Frysinger
2010-06-08 7:14 ` Wolfgang Denk
2010-06-08 13:01 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0E54F4.8000006@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.