From: Tejun Heo <tj@kernel.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jari Ruusu <jariruusu@users.sourceforge.net>,
Nick Piggin <npiggin@suse.de>, Jens Axboe <jens.axboe@oracle.com>
Subject: Re: 2.6.35-rc2 module reference counting broken
Date: Wed, 09 Jun 2010 09:01:58 +0200 [thread overview]
Message-ID: <4C0F3C66.1020601@kernel.org> (raw)
In-Reply-To: <20100608234814.GA19826@ZenIV.linux.org.uk>
Hello,
On 06/09/2010 01:48 AM, Al Viro wrote:
>> block: implement bd_claiming and claiming block
>>
>> I'm far too sleepy right now, but I'd start with reviewing what that
>> thing is doing to module refcounting...
>
> Yeah... bd_start_claiming() grabs a reference to gendisk and we never
> let it go. There's your leak...
Eh, I thought you were cc'd. Sorry. This was fixed sometime back by
Nick and queued in block tree (delayed due to mail misdelivery).
http://thread.gmane.org/gmane.linux.file-systems/40655
Thanks.
--
tejun
next prev parent reply other threads:[~2010-06-09 7:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 5:20 2.6.35-rc2 module reference counting broken Jari Ruusu
2010-06-07 6:44 ` Al Viro
2010-06-08 23:48 ` Al Viro
2010-06-09 7:01 ` Tejun Heo [this message]
2010-06-10 6:34 ` Jari Ruusu
2010-06-10 11:31 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0F3C66.1020601@kernel.org \
--to=tj@kernel.org \
--cc=jariruusu@users.sourceforge.net \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.