From: Tejun Heo <tj@kernel.org>
To: Jari Ruusu <jariruusu@users.sourceforge.net>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>, Jens Axboe <jens.axboe@oracle.com>
Subject: Re: 2.6.35-rc2 module reference counting broken
Date: Thu, 10 Jun 2010 13:31:07 +0200 [thread overview]
Message-ID: <4C10CCFB.4030203@kernel.org> (raw)
In-Reply-To: <4C108778.71545BCF@users.sourceforge.net>
Hello,
On 06/10/2010 08:34 AM, Jari Ruusu wrote:
> Later in the mount system call handling the module refrence count is
> incremented. But to me that looks like there is a window of opportunity for
> things to go wrong. What is there to prevent module from being removed at
> zero refcount?
It can be removed, in which case blkdev_get() fails and the whole open
attempt fails, which is the expected behavior. Claiming block just
needs access to the containing struct block_device, caring for the
actual device and backing module is blkdev_get()'s job.
Thanks.
--
tejun
prev parent reply other threads:[~2010-06-10 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 5:20 2.6.35-rc2 module reference counting broken Jari Ruusu
2010-06-07 6:44 ` Al Viro
2010-06-08 23:48 ` Al Viro
2010-06-09 7:01 ` Tejun Heo
2010-06-10 6:34 ` Jari Ruusu
2010-06-10 11:31 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C10CCFB.4030203@kernel.org \
--to=tj@kernel.org \
--cc=jariruusu@users.sourceforge.net \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.