Re: [PATCH] Add hook for custom xfer function in PATA Platform driver

[Graeme Russ <graeme.russ@gmail.com>]

On 27/05/10 00:05, Sergei Shtylyov wrote:
> Hello.
> 
> Graeme Russ wrote:
> 
>    Sorry for the belated reply, I've been somewhat busy.

Ditto - I really have not had much time to think more on this one.

To briefly sum up all the arguments, I see three options:

1) Write a new driver based on the PATA Platform driver specifically for my
needs
2) Add the 'custom data xfer hook' to both the PATA and IDE Platform
drivers and implement the 8-bit data xfer functions outside the driver
(board specific code)
3) Add an '8-bit xfer' flag to the PATA and IDE Platform drivers and add
the 8-bit data xfer in the driver

I see #1 as the lowest (zero) impact on current kernel code but #2 is by
far the most flexible and appears to follow driver design philosophy. #3 is
very restrictive and opens up a Pandora's Box of driver code hacks to
support each and every esoteric implementation.

If the consensus is on #2, I'll respin a new patch for both the PATA and
IDE Platform drivers

Regards,

Graeme