From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 6/6] apic: avoid using CPUState internals
Date: Thu, 10 Jun 2010 12:14:36 +0200 [thread overview]
Message-ID: <4C10BB0C.8080300@redhat.com> (raw)
In-Reply-To: <AANLkTinukX8kAE4fqFEJt6I5AN1qEynuzpslyLah0SjH@mail.gmail.com>
On 06/09/2010 09:59 PM, Blue Swirl wrote:
>>> struct APICState {
>>> - CPUState *cpu_env;
>>> + void *cpu_env;
>>
>> I proposed having an opaque CPUState type in hw/ but it was rejected. But I
>> don't think using a void pointer is any better.
>
> It's not necessary for the patch. Maybe it's possible to avoid all
> CPUState references in apic.c by pushing the dependencies to pc.c. It
> could affect performance though.
I think it's unnecessary. But I'd leave CPUState
Paolo
prev parent reply other threads:[~2010-06-10 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 21:31 [Qemu-devel] [PATCH 6/6] apic: avoid using CPUState internals Blue Swirl
2010-06-06 7:36 ` [Qemu-devel] " Jan Kiszka
2010-06-06 7:42 ` Blue Swirl
2010-06-06 17:39 ` Paolo Bonzini
2010-06-07 6:35 ` Markus Armbruster
2010-06-09 19:59 ` Blue Swirl
2010-06-10 10:14 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C10BB0C.8080300@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.