* [net-next PATCH] bnx2x: Fix link problem with some DACs
@ 2010-06-13 11:43 Yaniv Rosner
2010-06-13 21:27 ` Krzysztof Olędzki
0 siblings, 1 reply; 11+ messages in thread
From: Yaniv Rosner @ 2010-06-13 11:43 UTC (permalink / raw)
To: davem; +Cc: netdev
Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
Reported-by: Krzysztof Oldzki <ole@ans.pl>
Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
index a22a7e0..9b15b64 100644
--- a/drivers/net/bnx2x_link.c
+++ b/drivers/net/bnx2x_link.c
@@ -4274,7 +4274,7 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars)
ext_phy_addr,
MDIO_PMA_DEVAD,
MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
- 0xa001);
+ 0xa101);
/* Set TX PreEmphasis if needed */
if ((params->feature_config_flags &
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [net-next PATCH] bnx2x: Fix link problem with some DACs
2010-06-13 11:43 [net-next PATCH] bnx2x: Fix link problem with some DACs Yaniv Rosner
@ 2010-06-13 21:27 ` Krzysztof Olędzki
2010-06-14 0:52 ` David Miller
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Olędzki @ 2010-06-13 21:27 UTC (permalink / raw)
To: Yaniv Rosner; +Cc: davem, netdev
On 2010-06-13 13:43, Yaniv Rosner wrote:
> Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
>
> Reported-by: Krzysztof Oldzki <ole@ans.pl>
> Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> ---
> diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
> index a22a7e0..9b15b64 100644
> --- a/drivers/net/bnx2x_link.c
> +++ b/drivers/net/bnx2x_link.c
> @@ -4274,7 +4274,7 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars)
> ext_phy_addr,
> MDIO_PMA_DEVAD,
> MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
> - 0xa001);
> + 0xa101);
>
> /* Set TX PreEmphasis if needed */
> if ((params->feature_config_flags&
Tested-by: Krzysztof Piotr Oledzki <ole@ans.pl>
However, I believe the comment before this code should also be changed,
because it is now: "Set 2-wire transfer rate to 400Khz since 100Khz
is not operational ".
Thanks.
Best regards,
Krzysztof Olędzki
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [net-next PATCH] bnx2x: Fix link problem with some DACs
2010-06-13 21:27 ` Krzysztof Olędzki
@ 2010-06-14 0:52 ` David Miller
0 siblings, 0 replies; 11+ messages in thread
From: David Miller @ 2010-06-14 0:52 UTC (permalink / raw)
To: ole; +Cc: yanivr, netdev
From: Krzysztof Olędzki <ole@ans.pl>
Date: Sun, 13 Jun 2010 23:27:55 +0200
> On 2010-06-13 13:43, Yaniv Rosner wrote:
>> Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz
>> since some DACs(direct attached cables) do not work at 400Khz.
>>
>> Reported-by: Krzysztof Oldzki <ole@ans.pl>
>> Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
>> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
>> ---
>> diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
>> index a22a7e0..9b15b64 100644
>> --- a/drivers/net/bnx2x_link.c
>> +++ b/drivers/net/bnx2x_link.c
>> @@ -4274,7 +4274,7 @@ static u8 bnx2x_ext_phy_init(struct link_params
>> *params, struct link_vars *vars)
>> ext_phy_addr,
>> MDIO_PMA_DEVAD,
>> MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
>> - 0xa001);
>> + 0xa101);
>>
>> /* Set TX PreEmphasis if needed */
>> if ((params->feature_config_flags&
>
> Tested-by: Krzysztof Piotr Oledzki <ole@ans.pl>
>
> However, I believe the comment before this code should also be
> changed, because it is now: "Set 2-wire transfer rate to 400Khz since
> 100Khz
> is not operational ".
Agreed, Yaniv please update your patch.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [net-next PATCH] bnx2x: Fix link problem with some DACs
@ 2010-06-14 10:26 Yaniv Rosner
2010-06-14 8:49 ` Simon Horman
2010-06-15 6:07 ` David Miller
0 siblings, 2 replies; 11+ messages in thread
From: Yaniv Rosner @ 2010-06-14 10:26 UTC (permalink / raw)
To: davem; +Cc: netdev
Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
Reported-by: Krzysztof Oldzki <ole@ans.pl>
Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
index ff70be8..600bc44 100644
--- a/drivers/net/bnx2x_link.c
+++ b/drivers/net/bnx2x_link.c
@@ -4266,14 +4266,15 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars)
MDIO_PMA_REG_10G_CTRL2, 0x0008);
}
- /* Set 2-wire transfer rate to 400Khz since 100Khz
- is not operational */
+ /* Set 2-wire transfer rate of SFP+ module EEPROM
+ to 100Khz since some DACs(direct attached cables) do
+ not work at 400Khz.*/
bnx2x_cl45_write(bp, params->port,
ext_phy_type,
ext_phy_addr,
MDIO_PMA_DEVAD,
MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
- 0xa101);
+ 0xa001);
/* Set TX PreEmphasis if needed */
if ((params->feature_config_flags &
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [net-next PATCH] bnx2x: Fix link problem with some DACs
2010-06-14 10:26 Yaniv Rosner
@ 2010-06-14 8:49 ` Simon Horman
2010-06-14 9:04 ` Yaniv Rosner
2010-06-15 6:07 ` David Miller
1 sibling, 1 reply; 11+ messages in thread
From: Simon Horman @ 2010-06-14 8:49 UTC (permalink / raw)
To: Yaniv Rosner; +Cc: davem, netdev
On Mon, Jun 14, 2010 at 01:26:28PM +0300, Yaniv Rosner wrote:
> Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
>
> Reported-by: Krzysztof Oldzki <ole@ans.pl>
> Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> ---
> diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
> index ff70be8..600bc44 100644
> --- a/drivers/net/bnx2x_link.c
> +++ b/drivers/net/bnx2x_link.c
> @@ -4266,14 +4266,15 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars)
> MDIO_PMA_REG_10G_CTRL2, 0x0008);
> }
>
> - /* Set 2-wire transfer rate to 400Khz since 100Khz
> - is not operational */
Doesn't the above comment indicate there is some HW where 100Khz doesn't work?
> + /* Set 2-wire transfer rate of SFP+ module EEPROM
> + to 100Khz since some DACs(direct attached cables) do
> + not work at 400Khz.*/
> bnx2x_cl45_write(bp, params->port,
> ext_phy_type,
> ext_phy_addr,
> MDIO_PMA_DEVAD,
> MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
> - 0xa101);
> + 0xa001);
>
> /* Set TX PreEmphasis if needed */
> if ((params->feature_config_flags &
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [net-next PATCH] bnx2x: Fix link problem with some DACs
2010-06-14 8:49 ` Simon Horman
@ 2010-06-14 9:04 ` Yaniv Rosner
2010-06-14 9:18 ` Simon Horman
0 siblings, 1 reply; 11+ messages in thread
From: Yaniv Rosner @ 2010-06-14 9:04 UTC (permalink / raw)
To: Simon Horman
Cc: davem@davemloft.net, netdev@vger.kernel.org, Eilon Greenstein,
ole@ans.pl
Simon,
The previous comment refers to HW limitation of older PHY version which is related only to write operation that we don't do anyhow.
Regards,
Yaniv
-----Original Message-----
From: Simon Horman [mailto:horms@verge.net.au]
Sent: Monday, June 14, 2010 11:50 AM
To: Yaniv Rosner
Cc: davem@davemloft.net; netdev@vger.kernel.org
Subject: Re: [net-next PATCH] bnx2x: Fix link problem with some DACs
On Mon, Jun 14, 2010 at 01:26:28PM +0300, Yaniv Rosner wrote:
> Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
>
> Reported-by: Krzysztof Oldzki <ole@ans.pl>
> Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> ---
> diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
> index ff70be8..600bc44 100644
> --- a/drivers/net/bnx2x_link.c
> +++ b/drivers/net/bnx2x_link.c
> @@ -4266,14 +4266,15 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars)
> MDIO_PMA_REG_10G_CTRL2, 0x0008);
> }
>
> - /* Set 2-wire transfer rate to 400Khz since 100Khz
> - is not operational */
Doesn't the above comment indicate there is some HW where 100Khz doesn't work?
> + /* Set 2-wire transfer rate of SFP+ module EEPROM
> + to 100Khz since some DACs(direct attached cables) do
> + not work at 400Khz.*/
> bnx2x_cl45_write(bp, params->port,
> ext_phy_type,
> ext_phy_addr,
> MDIO_PMA_DEVAD,
> MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
> - 0xa101);
> + 0xa001);
>
> /* Set TX PreEmphasis if needed */
> if ((params->feature_config_flags &
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [net-next PATCH] bnx2x: Fix link problem with some DACs
2010-06-14 9:04 ` Yaniv Rosner
@ 2010-06-14 9:18 ` Simon Horman
0 siblings, 0 replies; 11+ messages in thread
From: Simon Horman @ 2010-06-14 9:18 UTC (permalink / raw)
To: Yaniv Rosner
Cc: davem@davemloft.net, netdev@vger.kernel.org, Eilon Greenstein,
ole@ans.pl
On Mon, Jun 14, 2010 at 02:04:17AM -0700, Yaniv Rosner wrote:
> Simon,
> The previous comment refers to HW limitation of older PHY version which is related only to write operation that we don't do anyhow.
Thanks for the clarification. In that case I have no objection.
>
> Regards,
> Yaniv
> -----Original Message-----
> From: Simon Horman [mailto:horms@verge.net.au]
> Sent: Monday, June 14, 2010 11:50 AM
> To: Yaniv Rosner
> Cc: davem@davemloft.net; netdev@vger.kernel.org
> Subject: Re: [net-next PATCH] bnx2x: Fix link problem with some DACs
>
> On Mon, Jun 14, 2010 at 01:26:28PM +0300, Yaniv Rosner wrote:
> > Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
> >
> > Reported-by: Krzysztof Oldzki <ole@ans.pl>
> > Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
> > Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
> > ---
> > diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
> > index ff70be8..600bc44 100644
> > --- a/drivers/net/bnx2x_link.c
> > +++ b/drivers/net/bnx2x_link.c
> > @@ -4266,14 +4266,15 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars)
> > MDIO_PMA_REG_10G_CTRL2, 0x0008);
> > }
> >
> > - /* Set 2-wire transfer rate to 400Khz since 100Khz
> > - is not operational */
>
> Doesn't the above comment indicate there is some HW where 100Khz doesn't work?
>
> > + /* Set 2-wire transfer rate of SFP+ module EEPROM
> > + to 100Khz since some DACs(direct attached cables) do
> > + not work at 400Khz.*/
> > bnx2x_cl45_write(bp, params->port,
> > ext_phy_type,
> > ext_phy_addr,
> > MDIO_PMA_DEVAD,
> > MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
> > - 0xa101);
> > + 0xa001);
> >
> > /* Set TX PreEmphasis if needed */
> > if ((params->feature_config_flags &
> >
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [net-next PATCH] bnx2x: Fix link problem with some DACs
2010-06-14 10:26 Yaniv Rosner
2010-06-14 8:49 ` Simon Horman
@ 2010-06-15 6:07 ` David Miller
2010-06-15 6:12 ` Yaniv Rosner
1 sibling, 1 reply; 11+ messages in thread
From: David Miller @ 2010-06-15 6:07 UTC (permalink / raw)
To: yanivr; +Cc: netdev
From: "Yaniv Rosner" <yanivr@broadcom.com>
Date: Mon, 14 Jun 2010 13:26:28 +0300
> - /* Set 2-wire transfer rate to 400Khz since 100Khz
> - is not operational */
> + /* Set 2-wire transfer rate of SFP+ module EEPROM
> + to 100Khz since some DACs(direct attached cables) do
> + not work at 400Khz.*/
This is not the correct way to format a multi-line comment.
It should be:
/* Set 2-wire transfer rate of SFP+ module EEPROM
* to 100Khz since some DACs(direct attached cables) do
* not work at 400Khz.
*/
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [net-next PATCH] bnx2x: Fix link problem with some DACs
2010-06-15 6:07 ` David Miller
@ 2010-06-15 6:12 ` Yaniv Rosner
0 siblings, 0 replies; 11+ messages in thread
From: Yaniv Rosner @ 2010-06-15 6:12 UTC (permalink / raw)
To: David Miller; +Cc: netdev@vger.kernel.org
Sure Dave,
I'll fix and send it again.
-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Tuesday, June 15, 2010 9:07 AM
To: Yaniv Rosner
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH] bnx2x: Fix link problem with some DACs
From: "Yaniv Rosner" <yanivr@broadcom.com>
Date: Mon, 14 Jun 2010 13:26:28 +0300
> - /* Set 2-wire transfer rate to 400Khz since 100Khz
> - is not operational */
> + /* Set 2-wire transfer rate of SFP+ module EEPROM
> + to 100Khz since some DACs(direct attached cables) do
> + not work at 400Khz.*/
This is not the correct way to format a multi-line comment.
It should be:
/* Set 2-wire transfer rate of SFP+ module EEPROM
* to 100Khz since some DACs(direct attached cables) do
* not work at 400Khz.
*/
^ permalink raw reply [flat|nested] 11+ messages in thread
* [net-next PATCH] bnx2x: Fix link problem with some DACs
@ 2010-06-15 8:22 Yaniv Rosner
2010-06-15 6:25 ` David Miller
0 siblings, 1 reply; 11+ messages in thread
From: Yaniv Rosner @ 2010-06-15 8:22 UTC (permalink / raw)
To: davem; +Cc: netdev, ole, eilong
Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
Reported-by: Krzysztof Oldzki <ole@ans.pl>
Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
index ff70be8..0383e30 100644
--- a/drivers/net/bnx2x_link.c
+++ b/drivers/net/bnx2x_link.c
@@ -4266,14 +4266,16 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, struct link_vars *vars)
MDIO_PMA_REG_10G_CTRL2, 0x0008);
}
- /* Set 2-wire transfer rate to 400Khz since 100Khz
- is not operational */
+ /* Set 2-wire transfer rate of SFP+ module EEPROM
+ * to 100Khz since some DACs(direct attached cables) do
+ * not work at 400Khz.
+ */
bnx2x_cl45_write(bp, params->port,
ext_phy_type,
ext_phy_addr,
MDIO_PMA_DEVAD,
MDIO_PMA_REG_8727_TWO_WIRE_SLAVE_ADDR,
- 0xa101);
+ 0xa001);
/* Set TX PreEmphasis if needed */
if ((params->feature_config_flags &
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [net-next PATCH] bnx2x: Fix link problem with some DACs
2010-06-15 8:22 Yaniv Rosner
@ 2010-06-15 6:25 ` David Miller
0 siblings, 0 replies; 11+ messages in thread
From: David Miller @ 2010-06-15 6:25 UTC (permalink / raw)
To: yanivr; +Cc: netdev, ole, eilong
From: "Yaniv Rosner" <yanivr@broadcom.com>
Date: Tue, 15 Jun 2010 11:22:43 +0300
> Change 2wire transfer rate of SFP+ module EEPROM from 400Khz to 100Khz since some DACs(direct attached cables) do not work at 400Khz.
>
> Reported-by: Krzysztof Oldzki <ole@ans.pl>
> Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2010-06-15 6:25 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-13 11:43 [net-next PATCH] bnx2x: Fix link problem with some DACs Yaniv Rosner
2010-06-13 21:27 ` Krzysztof Olędzki
2010-06-14 0:52 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-06-14 10:26 Yaniv Rosner
2010-06-14 8:49 ` Simon Horman
2010-06-14 9:04 ` Yaniv Rosner
2010-06-14 9:18 ` Simon Horman
2010-06-15 6:07 ` David Miller
2010-06-15 6:12 ` Yaniv Rosner
2010-06-15 8:22 Yaniv Rosner
2010-06-15 6:25 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.