[Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target

[Avi Kivity <avi@redhat.com>]

On 06/15/2010 03:04 PM, Avi Kivity wrote:
> On 06/15/2010 02:04 PM, Jes.Sorensen@redhat.com wrote:
>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>> Hi,
>>
>> This set of patches fixes building qemu-kvm for non KVM targets, as
>> reported in
>> http://sourceforge.net/tracker/?func=detail&atid=893831&aid=2984626&group_id=180599 
>>
>>
>> One of the main problem is that we have a tendency to move things from
>> Makefile.objs to Makefile.target in order to be able to use
>> TARGET_I386 etc in hw/*.c files. IMHO we need to start clamping down
>> on this harder and move things into separate files rather than the
>> #ifdef hacks. Hence this patch fixes the short term problem, but there
>> is more work to do for the longer term.
>
> It's the other way round.  Upstream keeps moving stuff out of 
> Makefile.target, and I move them back during merges, because the only 
> thing I can think of during a merge is "how quickly can I complete 
> this merge".
>
> Thanks for tackling this.
>

Oh, I though you actually moved things back.

Anyway,

Reviewed-by: Avi Kivity <avi@redhat.com>


-- 
error compiling committee.c: too many arguments to function