From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: avi@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h
Date: Tue, 15 Jun 2010 15:59:38 +0200 [thread overview]
Message-ID: <4C17874A.6090002@redhat.com> (raw)
In-Reply-To: <4C17815D.4060102@redhat.com>
On 06/15/10 15:34, Paolo Bonzini wrote:
> On 06/15/2010 01:04 PM, Jes.Sorensen@redhat.com wrote:
>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>> No need for kvm_init() stub in kvm-stub.c as already defined in
>> qemu-kvm.h
>
> Why not keep the other one and match upstream? Instead, I'd remove this
> one and move kvm_inject_x86_mce to kvm-stub.c.
>
> Files that upstream compiles only once will be compiled only without
> CONFIG_KVM, and will always call the stubs if these are in qemu-kvm.h.
You're right, time for a v3 of the patch....
Cheers,
Jes
next prev parent reply other threads:[~2010-06-15 14:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 11:04 [Qemu-devel] [PATCH 0/7] Fix building qemu-kvm for non KVM target Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 1/7] Only call kvm_set_irqfd() if CONFIG_KVM is defined Jes.Sorensen
2010-06-15 13:31 ` [Qemu-devel] " Paolo Bonzini
2010-06-15 13:40 ` Jes Sorensen
2010-06-15 13:48 ` Paolo Bonzini
2010-06-15 14:58 ` Michael S. Tsirkin
2010-06-15 11:04 ` [Qemu-devel] [PATCH 2/7] No need for kvm_init() stub as already defined in qemu-kvm.h Jes.Sorensen
2010-06-15 13:34 ` [Qemu-devel] " Paolo Bonzini
2010-06-15 13:59 ` Jes Sorensen [this message]
2010-06-15 11:04 ` [Qemu-devel] [PATCH 3/7] time_drift_fix is x86 only, rather than !ia64 Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 4/7] Build certain drivers for MIPS as well Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 5/7] Only export phys_mem create functions for !CONFIG_USER_ONLY builds Jes.Sorensen
2010-06-15 13:35 ` [Qemu-devel] " Paolo Bonzini
2010-06-15 11:04 ` [Qemu-devel] [PATCH 6/7] Only treat KVM specific cmdline options for KVM enabled builds Jes.Sorensen
2010-06-15 11:04 ` [Qemu-devel] [PATCH 7/7] Only accept -no-hpet for i386 targets Jes.Sorensen
2010-06-15 12:20 ` [Qemu-devel] " Jan Kiszka
2010-06-15 12:28 ` Jes Sorensen
2010-06-15 12:37 ` Jan Kiszka
2010-06-15 12:44 ` Jes Sorensen
2010-06-15 13:38 ` Paolo Bonzini
2010-06-15 13:42 ` Jes Sorensen
2010-06-15 12:04 ` [Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM target Avi Kivity
2010-06-15 12:06 ` Avi Kivity
2010-06-15 12:10 ` Jes Sorensen
2010-06-15 13:42 ` Juan Quintela
2010-06-15 13:44 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C17874A.6090002@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=avi@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.