Re-enable dithering after commit a7b9f9e5adef276c25584e28ce9e520045ff048b

Re-enable dithering after commit a7b9f9e5adef276c25584e28ce9e520045ff048b

[Martin Peres]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

Hi everyone,

After commit a7b9f9e5adef276c25584e28ce9e520045ff048b, dithering has 
disappeared on LVDS (for those who needed it).

ThibG on IRC has bisected this behaviour to 
a7b9f9e5adef276c25584e28ce9e520045ff048b. Here is a patch that 
re-enables it.

Please comment on it.

Martin

[-- Attachment #2: re-enable_dithering_on_less_than_24bits_lvds_v2.path --]
[-- Type: text/plain, Size: 1281 bytes --]

diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index d865707..f8cfab0 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -736,7 +736,8 @@ nouveau_connector_create(struct drm_device *dev,
 	struct nouveau_connector *nv_connector = NULL;
 	struct drm_connector *connector;
 	struct drm_encoder *encoder;
-	int type;
+	bool dummy, if_is_24bit = false;
+	int ret, type;
 
 	NV_DEBUG_KMS(dev, "\n");
 
@@ -823,6 +824,20 @@ nouveau_connector_create(struct drm_device *dev,
 		drm_connector_attach_property(connector, dev->mode_config.dvi_i_subconnector_property, 0);
 		drm_connector_attach_property(connector, dev->mode_config.dvi_i_select_subconnector_property, 0);
 	}
+	
+	/* Parse the LVDS table to get if it has a 24-bit link depth.
+	* If it hasn't, make use dithering to smooth shadings.
+	*/
+	if (dcb->type == DCB_CONNECTOR_LVDS) {
+		ret = nouveau_bios_parse_lvds_table(dev, 0, &dummy, &if_is_24bit);
+		if (ret) {
+			NV_ERROR(dev, "Error parsing LVDS table, disabling LVDS\n");
+			drm_connector_cleanup(connector);
+			kfree(connector);
+			return 0;
+		}
+		nv_connector->use_dithering = !if_is_24bit;
+	}
 
 	switch (dcb->type) {
 	case DCB_CONNECTOR_VGA:

[-- Attachment #3: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: Re-enable dithering after commit a7b9f9e5adef276c25584e28ce9e520045ff048b

[Martin Peres]

Le 16/06/2010 09:38, Martin Peres a écrit :
> Hi everyone,
>
> After commit a7b9f9e5adef276c25584e28ce9e520045ff048b, dithering has 
> disappeared on LVDS (for those who needed it).
>
> ThibG on IRC has bisected this behaviour to 
> a7b9f9e5adef276c25584e28ce9e520045ff048b. Here is a patch that 
> re-enables it.
>
> Please comment on it.
>
> Martin
Well, too late, Jerez already pushed a patch to do that :)

Do you have any idea of why it took almost 10 hours between the moment I 
sent this mail and the moment I actually received it from the list ? Is 
there a manual approbation somewhere to get rid of the spam ?

Thanks to Jerez for the patch anyway :) It works just as great and is 
better designed.

Re: Re-enable dithering after commit a7b9f9e5adef276c25584e28ce9e520045ff048b

[Stephane Marchesin]

[-- Attachment #1.1: Type: text/plain, Size: 837 bytes --]

On Wed, Jun 16, 2010 at 10:24, Martin Peres <martin.peres-Iz16wY1oaNPLSKGbIzaifA@public.gmane.org>wrote:

> Le 16/06/2010 09:38, Martin Peres a écrit :
>
>  Hi everyone,
>>
>> After commit a7b9f9e5adef276c25584e28ce9e520045ff048b, dithering has
>> disappeared on LVDS (for those who needed it).
>>
>> ThibG on IRC has bisected this behaviour to
>> a7b9f9e5adef276c25584e28ce9e520045ff048b. Here is a patch that re-enables
>> it.
>>
>> Please comment on it.
>>
>> Martin
>>
> Well, too late, Jerez already pushed a patch to do that :)
>
> Do you have any idea of why it took almost 10 hours between the moment I
> sent this mail and the moment I actually received it from the list ? Is
> there a manual approbation somewhere to get rid of the spam ?
>

Yes, because you're not subscribed to the list.

Stephane

[-- Attachment #1.2: Type: text/html, Size: 1341 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

Re: Re-enable dithering after commit a7b9f9e5adef276c25584e28ce9e520045ff048b

[Martin Peres]

[-- Attachment #1.1: Type: text/plain, Size: 591 bytes --]

Le 17/06/2010 21:36, Stephane Marchesin a écrit :
>
>
> On Wed, Jun 16, 2010 at 10:24, Martin Peres 
> <martin.peres-Iz16wY1oaNPLSKGbIzaifA@public.gmane.org <mailto:martin.peres-Iz16wY1oaNPLSKGbIzaifA@public.gmane.org>> 
> wrote:
>
>
>     Do you have any idea of why it took almost 10 hours between the
>     moment I sent this mail and the moment I actually received it from
>     the list ? Is there a manual approbation somewhere to get rid of
>     the spam ?
>
>
> Yes, because you're not subscribed to the list.
>
> Stephane
Woops, used the wrong adress, my bad ...

[-- Attachment #1.2: Type: text/html, Size: 1198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau