[PATCH CANDIDATE] ia64: Fix xc_save error reporting

[PATCH CANDIDATE] ia64: Fix xc_save error reporting

[Michal Novotny]

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

Hi,
this is the patch for error reporting on ia64 that has a special 
handling in comparison with i386/x86_64 platforms. This is pretty 
straight-forward just to fail on "cannot map mfn page" message instead 
of continue since the memory is not being correctly mapped using the 
xc_map_foreign_range() function.

This patch has been originally done for RHEL-5 version of Xen, tested 
and working fine on RHEL-5 but when I had a look at Xen-unstable I saw 
that is *may* be the issue there as well. Unfortunately I'm not having 
any ia64 machine where I can install Xen-unstable so could somebody 
please test this patch on Xen-unstable ? Nevertheless, since the code is 
pretty similar for both RHEL-5 Xen and Xen-unstable it should work the 
same, i.e. it should be working but unfortunately I can't test it :(

Thanks a lot,
Michal

-- 
Michal Novotny<minovotn@redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat


[-- Attachment #2: xen-ia64-save-failure-report-error.patch --]
[-- Type: text/x-patch, Size: 606 bytes --]

diff -r 0eeda0176d87 tools/libxc/ia64/xc_ia64_linux_save.c
--- a/tools/libxc/ia64/xc_ia64_linux_save.c	Mon Jun 07 07:49:07 2010 +0100
+++ b/tools/libxc/ia64/xc_ia64_linux_save.c	Thu Jun 17 17:35:32 2010 +0200
@@ -647,7 +647,7 @@ xc_domain_save(xc_interface *xc_handle, 
                     fprintf(stderr, "cannot map mfn page %lx gpfn %lx: %s\n",
                             xc_ia64_p2m_mfn(&p2m_table, N),
                             N, safe_strerror(errno));
-                    continue;
+                    goto out;
                 }
 
                 if (write_exact(io_fd, &N, sizeof(N))) {

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel