From: "Michael Büsch" <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: [PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode
Date: Sat, 19 Jun 2010 16:01:07 +0200 [thread overview]
Message-ID: <4C1CCDA3.40502@bu3sch.de> (raw)
In-Reply-To: <4c1cc624.Whz955JR9XYzqjst%Larry.Finger@lwfinger.net> (sfid-20100619_152832_048688_17D51150)
On 06/19/2010 03:29 PM, Larry Finger wrote:
> The message following fatal DMA errors fails to indicate properly that the
> driver has switched to PIO mode.
>
> Signed-off-by: Larry Finger<Larry.Finger@wfinger.net>
> ---
>
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
> +++ wireless-testing/drivers/net/wireless/b43/main.c
> @@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
> dma_reason[2], dma_reason[3],
> dma_reason[4], dma_reason[5]);
> b43err(dev->wl, "This device does not support DMA "
> - "on your system. Please use PIO instead.\n");
> + "on your system. It will now be switched to PIO.\n");
> /* Fall back to PIO transfers if we get fatal DMA errors! */
> dev->use_pio = 1;
> b43_controller_restart(dev, "DMA error");
>
Ack.
But what's the current status of the debugging of the PCI-core code
w.r.t DMA?
--
Greetings Michael.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode
Date: Sat, 19 Jun 2010 16:01:07 +0200 [thread overview]
Message-ID: <4C1CCDA3.40502@bu3sch.de> (raw)
In-Reply-To: <4c1cc624.Whz955JR9XYzqjst%Larry.Finger@lwfinger.net> (sfid-20100619_152832_048688_17D51150)
On 06/19/2010 03:29 PM, Larry Finger wrote:
> The message following fatal DMA errors fails to indicate properly that the
> driver has switched to PIO mode.
>
> Signed-off-by: Larry Finger<Larry.Finger@wfinger.net>
> ---
>
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
> +++ wireless-testing/drivers/net/wireless/b43/main.c
> @@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
> dma_reason[2], dma_reason[3],
> dma_reason[4], dma_reason[5]);
> b43err(dev->wl, "This device does not support DMA "
> - "on your system. Please use PIO instead.\n");
> + "on your system. It will now be switched to PIO.\n");
> /* Fall back to PIO transfers if we get fatal DMA errors! */
> dev->use_pio = 1;
> b43_controller_restart(dev, "DMA error");
>
Ack.
But what's the current status of the debugging of the PCI-core code
w.r.t DMA?
--
Greetings Michael.
next prev parent reply other threads:[~2010-06-19 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 13:29 [PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode Larry Finger
2010-06-19 13:58 ` Michael Büsch
2010-06-19 14:05 ` Larry Finger
2010-06-19 15:35 ` Rafał Miłecki
2010-06-19 18:25 ` Larry Finger
2010-06-21 15:00 ` John W. Linville
2010-06-19 14:01 ` Michael Büsch [this message]
2010-06-19 14:01 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1CCDA3.40502@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.