From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Alessandro Guido <ag@alessandroguido.name>
Cc: linux-kernel@vger.kernel.org, zippel@linux-m68k.org,
linux-fsdevel@vger.kernel.org, rusty@rustcorp.com.au,
linux-audit@redhat.com
Subject: Re: [PATCH 3/6]cifs Fix variable not set warnings
Date: Sun, 20 Jun 2010 06:29:04 -0700 [thread overview]
Message-ID: <4C1E17A0.8010202@gmail.com> (raw)
In-Reply-To: <4C1E1602.7080700@alessandroguido.name>
On 06/20/2010 06:22 AM, Alessandro Guido wrote:
>> ...
>> @@ -734,7 +733,6 @@ cifs_lookup(struct inode *parent_dir_inode, struct
>> dentry *direntry,
>> direntry->d_op =&cifs_dentry_ops;
>> d_add(direntry, newInode);
>> if (posix_open)
>> - filp = lookup_instantiate_filp(nd, direntry, NULL);
>> /* since paths are not looked up by component - the parent
>> directories are presumed to be good here */
>> renew_parental_timestamps(direntry);
>> ...
>
> This is wrong, now "renew_parental_timestamps(direntry)" is in the if body.
>
>
>
have you had a chance to look at the later one I had sent in yesterday?
if so out of the two, which might be a better bet(keep in mind the first
set has whitespace issues).
Justin P. Mattock
next prev parent reply other threads:[~2010-06-20 13:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 20:41 [PATCH 0/6] Fix gcc warnings of unused variables etc Justin P. Mattock
2010-06-11 20:41 ` [PATCH 1/6]scripts:conf.c Fix warning: variable 'type' set but not used Justin P. Mattock
2010-06-11 22:19 ` Michal Marek
2010-06-11 22:24 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 2/6]kernel:audit.c Fix warning: variable 'nlh' " Justin P. Mattock
2010-06-11 21:14 ` Geert Uytterhoeven
2010-06-11 21:14 ` Geert Uytterhoeven
2010-06-11 22:03 ` Justin P. Mattock
2010-06-19 4:45 ` Justin P. Mattock
2010-06-19 8:06 ` Geert Uytterhoeven
2010-06-19 8:06 ` Geert Uytterhoeven
2010-06-19 13:29 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 3/6]cifs Fix variable not set warnings Justin P. Mattock
2010-06-11 20:41 ` Justin P. Mattock
2010-06-20 13:22 ` Alessandro Guido
2010-06-20 13:29 ` Justin P. Mattock [this message]
2010-06-11 20:41 ` [PATCH 4/6]hfs Fix variable set but not used Justin P. Mattock
2010-06-11 20:41 ` [PATCH 5/6]kernel:module.c variable 'nowarn' " Justin P. Mattock
2010-06-11 21:17 ` Geert Uytterhoeven
2010-06-11 21:17 ` Geert Uytterhoeven
2010-06-11 22:06 ` Justin P. Mattock
2010-06-19 5:04 ` Justin P. Mattock
2010-06-19 8:08 ` Geert Uytterhoeven
2010-06-19 13:41 ` Justin P. Mattock
2010-06-19 19:10 ` Justin P. Mattock
2010-06-19 19:45 ` Geert Uytterhoeven
2010-06-19 19:45 ` Geert Uytterhoeven
2010-06-19 20:10 ` Justin P. Mattock
2010-06-19 20:23 ` Geert Uytterhoeven
2010-06-19 20:26 ` Justin P. Mattock
2010-06-11 20:41 ` [PATCH 6/6]afs:fsclient.c Fix variable 'bp' " Justin P. Mattock
2010-06-11 20:41 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1E17A0.8010202@gmail.com \
--to=justinmattock@gmail.com \
--cc=ag@alessandroguido.name \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.