From: Daniel Golle <daniel.golle@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC] refactor ath9k_platform to sound sane for use in both ath9k and ath5k
Date: Mon, 21 Jun 2010 13:48:51 +0200 [thread overview]
Message-ID: <4C1F51A3.5000407@gmail.com> (raw)
I'm developing on OpenWrt to work with EEPROM-less ath5k mini-pci
devices. This is needed to support the ar71xx-based Senao EAP7660D board
which got two AR5413 modules soldered into its mini-pci slots. In the
original Firmware, MAC addresses as well as calibration-data seems to be
part of the firmware blob stored on the board flash.
See
https://lists.openwrt.org/pipermail/openwrt-devel/2010-June/007366.html
for the corresponding discussion on OpenWrt-devel.
Similarly to the way this happens for ath9k, I managed to get ath5k to
use the MAC address and eeprom-data supplied by ath9k_platform_data.
Including ath9k_platform.h in ath5k-sources looks confusing as the name
ath9k_platform suggests that the supplied ath9k_platform_info struct is
specific to ath9k devices.
Consequently, I believe ath9k_platform.h should be renamed into
ath_platform.h, the macro ATH9K_PLAT_EEP_MAX_WORDS into
ATH_PLAT_EEP_MAX_WORDS and struct ath9k_platform_data should be
refactored to be struct ath_platform_data.
Please let me know if you agree with this in theory; if yes, I'll start
posting the patches to OpenWrt.
Cheers
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel.golle@gmail.com>
To: linux-wireless@vger.kernel.org, ath5k-devel@lists.ath5k.org,
ath9k-devel@lists.ath9k.org
Subject: [RFC] refactor ath9k_platform to sound sane for use in both ath9k and ath5k
Date: Mon, 21 Jun 2010 13:48:51 +0200 [thread overview]
Message-ID: <4C1F51A3.5000407@gmail.com> (raw)
I'm developing on OpenWrt to work with EEPROM-less ath5k mini-pci
devices. This is needed to support the ar71xx-based Senao EAP7660D board
which got two AR5413 modules soldered into its mini-pci slots. In the
original Firmware, MAC addresses as well as calibration-data seems to be
part of the firmware blob stored on the board flash.
See
https://lists.openwrt.org/pipermail/openwrt-devel/2010-June/007366.html
for the corresponding discussion on OpenWrt-devel.
Similarly to the way this happens for ath9k, I managed to get ath5k to
use the MAC address and eeprom-data supplied by ath9k_platform_data.
Including ath9k_platform.h in ath5k-sources looks confusing as the name
ath9k_platform suggests that the supplied ath9k_platform_info struct is
specific to ath9k devices.
Consequently, I believe ath9k_platform.h should be renamed into
ath_platform.h, the macro ATH9K_PLAT_EEP_MAX_WORDS into
ATH_PLAT_EEP_MAX_WORDS and struct ath9k_platform_data should be
refactored to be struct ath_platform_data.
Please let me know if you agree with this in theory; if yes, I'll start
posting the patches to OpenWrt.
Cheers
Daniel
next reply other threads:[~2010-06-21 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 11:48 Daniel Golle [this message]
2010-06-21 11:48 ` [RFC] refactor ath9k_platform to sound sane for use in both ath9k and ath5k Daniel Golle
2010-06-21 18:02 ` [ath9k-devel] " Luis R. Rodriguez
2010-06-21 18:02 ` Luis R. Rodriguez
2010-07-23 2:02 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1F51A3.5000407@gmail.com \
--to=daniel.golle@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.