* [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
@ 2010-06-21 20:46 Albert Aribaud
2010-06-22 6:20 ` Prafulla Wadaskar
2010-06-22 6:29 ` Prafulla Wadaskar
0 siblings, 2 replies; 6+ messages in thread
From: Albert Aribaud @ 2010-06-21 20:46 UTC (permalink / raw)
To: u-boot
Signed-off-by: Albert Aribaud <albert.aribaud@free.fr>
---
Orion5x MPP and GPIO setting code had writel arguments
the wrong way around. Fixed and tested.
arch/arm/cpu/arm926ejs/orion5x/cpu.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/orion5x/cpu.c b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
index c2f5253..03c6d06 100644
--- a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
+++ b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
@@ -260,10 +260,10 @@ int arch_misc_init(void)
/* Set CPIOs and MPPs - values provided by board
include file */
- writel(ORION5X_MPP_BASE+0x00, ORION5X_MPP0_7);
- writel(ORION5X_MPP_BASE+0x04, ORION5X_MPP8_15);
- writel(ORION5X_MPP_BASE+0x50, ORION5X_MPP16_23);
- writel(ORION5X_GPIO_BASE+0x04, ORION5X_GPIO_OUT_ENABLE);
+ writel(ORION5X_MPP0_7, ORION5X_MPP_BASE+0x00);
+ writel(ORION5X_MPP8_15, ORION5X_MPP_BASE+0x04);
+ writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50);
+ writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04);
return 0;
}
--
1.6.4.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
2010-06-21 20:46 [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments Albert Aribaud
@ 2010-06-22 6:20 ` Prafulla Wadaskar
2010-06-22 6:32 ` Prafulla Wadaskar
2010-06-22 6:42 ` Albert ARIBAUD
2010-06-22 6:29 ` Prafulla Wadaskar
1 sibling, 2 replies; 6+ messages in thread
From: Prafulla Wadaskar @ 2010-06-22 6:20 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
> Sent: Tuesday, June 22, 2010 2:17 AM
> To: u-boot at lists.denx.de
> Subject: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO
> writel arguments
>
>
> Signed-off-by: Albert Aribaud <albert.aribaud@free.fr>
> ---
> Orion5x MPP and GPIO setting code had writel arguments
> the wrong way around. Fixed and tested.
>
> arch/arm/cpu/arm926ejs/orion5x/cpu.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> index c2f5253..03c6d06 100644
> --- a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> +++ b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> @@ -260,10 +260,10 @@ int arch_misc_init(void)
>
> /* Set CPIOs and MPPs - values provided by board
> include file */
> - writel(ORION5X_MPP_BASE+0x00, ORION5X_MPP0_7);
> - writel(ORION5X_MPP_BASE+0x04, ORION5X_MPP8_15);
> - writel(ORION5X_MPP_BASE+0x50, ORION5X_MPP16_23);
> - writel(ORION5X_GPIO_BASE+0x04, ORION5X_GPIO_OUT_ENABLE);
> + writel(ORION5X_MPP0_7, ORION5X_MPP_BASE+0x00);
> + writel(ORION5X_MPP8_15, ORION5X_MPP_BASE+0x04);
> + writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50);
> + writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04);
This means, earlier patches you posted were not tested properly.
Its great trust on the developers that whatever they submit (even smallest change) is tested.
Submitting untested/unused code is strongly discouraged...
I hope everyone agrees with me.
Regards..
Prafulla . .
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
2010-06-22 6:20 ` Prafulla Wadaskar
@ 2010-06-22 6:32 ` Prafulla Wadaskar
2010-06-22 20:38 ` Wolfgang Denk
2010-06-22 6:42 ` Albert ARIBAUD
1 sibling, 1 reply; 6+ messages in thread
From: Prafulla Wadaskar @ 2010-06-22 6:32 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Prafulla Wadaskar
> Sent: Tuesday, June 22, 2010 11:51 AM
> To: Albert Aribaud; u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO
> writel arguments
>
>
>
> > -----Original Message-----
> > From: u-boot-bounces at lists.denx.de
> > [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
> > Sent: Tuesday, June 22, 2010 2:17 AM
> > To: u-boot at lists.denx.de
> > Subject: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO
> > writel arguments
> >
> >
> > Signed-off-by: Albert Aribaud <albert.aribaud@free.fr>
> > ---
> > Orion5x MPP and GPIO setting code had writel arguments
> > the wrong way around. Fixed and tested.
Hi Wolfgang
The same is available at
http://git.denx.de/?p=u-boot/u-boot-marvell.git;a=commit;h=df33d8b1e1be6111366a3fd51751c9419fc2df5a
Please kindly pull it from u-boot-marvell.git master branch, I have modified original patch little bit for patch comments
Regards..
Prafulla . . .
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
2010-06-22 6:32 ` Prafulla Wadaskar
@ 2010-06-22 20:38 ` Wolfgang Denk
0 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2010-06-22 20:38 UTC (permalink / raw)
To: u-boot
Dear Prafulla Wadaskar,
In message <F766E4F80769BD478052FB6533FA745D19A4985705@SC-VEXCH4.marvell.com> you wrote:
>
> The same is available at
> http://git.denx.de/?p=3Du-boot/u-boot-marvell.git;a=3Dcommit;h=3Ddf33d8b1e1=
> be6111366a3fd51751c9419fc2df5a
>
> Please kindly pull it from u-boot-marvell.git master branch, I have modifie=
> d original patch little bit for patch comments
I'm not sure if htis was a pull request - in case it was, please
resend it as such.
So far, I just cherry-picked this single commit.
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Gods don't like people not doing much work. People who aren't busy
all the time might start to _think_. - Terry Pratchett, _Small Gods_
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
2010-06-22 6:20 ` Prafulla Wadaskar
2010-06-22 6:32 ` Prafulla Wadaskar
@ 2010-06-22 6:42 ` Albert ARIBAUD
1 sibling, 0 replies; 6+ messages in thread
From: Albert ARIBAUD @ 2010-06-22 6:42 UTC (permalink / raw)
To: u-boot
Le 22/06/2010 08:20, Prafulla Wadaskar a ?crit :
> This means, earlier patches you posted were not tested properly.
> Its great trust on the developers that whatever they submit (even smallest change) is tested.
> Submitting untested/unused code is strongly discouraged...
>
> I hope everyone agrees with me.
I agree and do apologize.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments
2010-06-21 20:46 [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments Albert Aribaud
2010-06-22 6:20 ` Prafulla Wadaskar
@ 2010-06-22 6:29 ` Prafulla Wadaskar
1 sibling, 0 replies; 6+ messages in thread
From: Prafulla Wadaskar @ 2010-06-22 6:29 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
> Sent: Tuesday, June 22, 2010 2:17 AM
> To: u-boot at lists.denx.de
> Subject: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO
> writel arguments
>
>
> Signed-off-by: Albert Aribaud <albert.aribaud@free.fr>
> ---
> Orion5x MPP and GPIO setting code had writel arguments
> the wrong way around. Fixed and tested.
>
> arch/arm/cpu/arm926ejs/orion5x/cpu.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> index c2f5253..03c6d06 100644
> --- a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> +++ b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> @@ -260,10 +260,10 @@ int arch_misc_init(void)
>
> /* Set CPIOs and MPPs - values provided by board
> include file */
> - writel(ORION5X_MPP_BASE+0x00, ORION5X_MPP0_7);
> - writel(ORION5X_MPP_BASE+0x04, ORION5X_MPP8_15);
> - writel(ORION5X_MPP_BASE+0x50, ORION5X_MPP16_23);
> - writel(ORION5X_GPIO_BASE+0x04, ORION5X_GPIO_OUT_ENABLE);
> + writel(ORION5X_MPP0_7, ORION5X_MPP_BASE+0x00);
> + writel(ORION5X_MPP8_15, ORION5X_MPP_BASE+0x04);
> + writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50);
> + writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04);
>
Applied to u-boot-marvell.git master branch
Regards..
Prafulla . .
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-06-22 20:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-21 20:46 [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments Albert Aribaud
2010-06-22 6:20 ` Prafulla Wadaskar
2010-06-22 6:32 ` Prafulla Wadaskar
2010-06-22 20:38 ` Wolfgang Denk
2010-06-22 6:42 ` Albert ARIBAUD
2010-06-22 6:29 ` Prafulla Wadaskar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.