All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ocaml: remove bogus /dev/xen/ev[en]tchn
@ 2010-06-23 21:22 Jeremy Fitzhardinge
  0 siblings, 0 replies; only message in thread
From: Jeremy Fitzhardinge @ 2010-06-23 21:22 UTC (permalink / raw)
  To: Ian Jackson; +Cc: Xen-devel, Vincent Hanquez, Ian Campbell

Oxenstored should not try to create the evtchn device, as it:

    * creates the wrong name (/dev/xen/eventchn rather than evtchn)
    * uses a hard-coded minor number, even though this dynamically
      depends on what other misc devices are in the kernel

Remove all this code and just rely on the system to create the device.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

diff -r a24dbfcbdf69 tools/ocaml/libs/eventchn/eventchn_stubs.c
--- a/tools/ocaml/libs/eventchn/eventchn_stubs.c	Tue Jun 22 07:19:38 2010 +0100
+++ b/tools/ocaml/libs/eventchn/eventchn_stubs.c	Wed Jun 23 22:17:29 2010 +0100
@@ -34,10 +34,7 @@
 #include <caml/callback.h>
 #include <caml/fail.h>
 
-#define EVENTCHN_PATH "/dev/xen/eventchn"
-
-static int eventchn_major = 10;
-static int eventchn_minor = 61;
+#define EVENTCHN_PATH "/dev/xen/evtchn"
 
 static int do_ioctl(int handle, int cmd, void *arg)
 {
@@ -56,15 +53,7 @@
 
 int eventchn_do_open(void)
 {
-	int fd;
-
-	fd = open(EVENTCHN_PATH, O_RDWR);
-	if (fd == -1 && errno == ENOENT) {
-		mkdir("/dev/xen", 0640);
-		mknod(EVENTCHN_PATH, S_IFCHR | 0640, makedev(eventchn_major, eventchn_minor));
-		fd = open(EVENTCHN_PATH, O_RDWR);
-	}
-	return fd;
+	return open(EVENTCHN_PATH, O_RDWR);
 }
 
 CAMLprim value stub_eventchn_init(value unit)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-23 21:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-23 21:22 [PATCH] ocaml: remove bogus /dev/xen/ev[en]tchn Jeremy Fitzhardinge

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.