All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: "Diego Elio “Flameeyes” Pettenò" <flameeyes@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp: implement SIOCINQ ioctl()
Date: Thu, 24 Jun 2010 13:58:30 +0000	[thread overview]
Message-ID: <4C236486.5070708@hp.com> (raw)
In-Reply-To: <1277387081.13544.75.camel@yamato.local>



Diego Elio “Flameeyes” Pettenò wrote:
> Il giorno gio, 24/06/2010 alle 09.40 -0400, Vlad Yasevich ha scritto:
>> You don't call accept() on an SCTP SEQPACKET socket.  You can just
>> read from it.
> 
> Okay I guess I'll send a patch to the man page to fix that then.

I don't think the man page needs an update.  This is just an SCTP-ism.
There are other protocols using SOCK_SEQPACKET that implement and support
accept() call.

The SCTP api spec decided that it wouldn't support accept() and we have to
follow it.


> 
>> This way, you'll ignore listening SOCK_STREAM sockets which will not
>> have any
>> data anyway, but you'll check out listening SOCK_SEQPACKET sockets
>> that may have
>> data waiting on them. 
> 
> Ah I think I see what you mean here: SIOCINQ would work for TCP-style
> ESTABLISHED sockets _and_ SEQPACKET LISTENING sockets, right?

Right.

-vlad

> 
> Will send the updated patch in a moment.
> 

WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: "Diego Elio “Flameeyes” Pettenò" <flameeyes@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp: implement SIOCINQ ioctl()
Date: Thu, 24 Jun 2010 09:58:30 -0400	[thread overview]
Message-ID: <4C236486.5070708@hp.com> (raw)
In-Reply-To: <1277387081.13544.75.camel@yamato.local>



Diego Elio “Flameeyes” Pettenò wrote:
> Il giorno gio, 24/06/2010 alle 09.40 -0400, Vlad Yasevich ha scritto:
>> You don't call accept() on an SCTP SEQPACKET socket.  You can just
>> read from it.
> 
> Okay I guess I'll send a patch to the man page to fix that then.

I don't think the man page needs an update.  This is just an SCTP-ism.
There are other protocols using SOCK_SEQPACKET that implement and support
accept() call.

The SCTP api spec decided that it wouldn't support accept() and we have to
follow it.


> 
>> This way, you'll ignore listening SOCK_STREAM sockets which will not
>> have any
>> data anyway, but you'll check out listening SOCK_SEQPACKET sockets
>> that may have
>> data waiting on them. 
> 
> Ah I think I see what you mean here: SIOCINQ would work for TCP-style
> ESTABLISHED sockets _and_ SEQPACKET LISTENING sockets, right?

Right.

-vlad

> 
> Will send the updated patch in a moment.
> 

  reply	other threads:[~2010-06-24 13:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-23 21:37 [PATCH] sctp: implement SIOCINQ ioctl() 
2010-06-23 21:37 ` Diego Elio 'Flameeyes' Pettenò
2010-06-24 13:19 ` Vlad Yasevich
2010-06-24 13:19   ` Vlad Yasevich
2010-06-24 13:20   ` 
2010-06-24 13:20     ` Diego Elio “Flameeyes” Pettenò
2010-06-24 13:40     ` Vlad Yasevich
2010-06-24 13:40       ` Vlad Yasevich
2010-06-24 13:44       ` 
2010-06-24 13:44         ` Diego Elio “Flameeyes” Pettenò
2010-06-24 13:58         ` Vlad Yasevich [this message]
2010-06-24 13:58           ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C236486.5070708@hp.com \
    --to=vladislav.yasevich@hp.com \
    --cc=flameeyes@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.