* [PATCH 1/1] Daily snapshot not building on 2.6.32
@ 2010-06-23 18:37 Brad Figg
2010-06-24 6:27 ` Takashi Iwai
0 siblings, 1 reply; 13+ messages in thread
From: Brad Figg @ 2010-06-23 18:37 UTC (permalink / raw)
To: alsa-devel
I've had to apply the following patch to successfully build
the daily snapshot on 2.6.32. Without this patch I get:
CC [M] /karmic/home/work/alsa/alsa-driver/usb/urb.o
/karmic/home/work/alsa/alsa-driver/usb/urb.c: In function ‘release_urb_ctx’:
/karmic/home/work/alsa/alsa-driver/usb/urb.c:112: error: implicit declaration of function ‘usb_free_
coherent’
/karmic/home/work/alsa/alsa-driver/usb/urb.c: In function ‘snd_usb_init_substream_urbs’:
/karmic/home/work/alsa/alsa-driver/usb/urb.c:327: error: implicit declaration of function ‘usb_alloc_coherent’
/karmic/home/work/alsa/alsa-driver/usb/urb.c:328: warning: assignment makes pointer from integer without a cast
/karmic/home/work/alsa/alsa-driver/usb/urb.c:341: warning: assignment makes pointer from integer without a cast
make[3]: *** [/karmic/home/work/alsa/alsa-driver/usb/urb.o] Error 1
Note: I would have preferred to provide this as a git patch
but I don't know where the repository for the daily
snapshot files is located.
---
diff -ru a/usb/misc/Makefile b/usb/misc/Makefile
--- a/usb/misc/Makefile 2010-03-10 01:12:19.000000000 -0800
+++ b/usb/misc/Makefile 2010-06-23 11:25:33.176133657 -0700
@@ -7,4 +7,8 @@
include $(SND_TOPDIR)/alsa-kernel/usb/misc/Makefile
+EXTRA_CFLAGS += -I$(SND_TOPDIR)/usb
+
include $(SND_TOPDIR)/Rules.make
+
+ua101.c: usbaudio.inc $(SND_TOPDIR)/alsa-kernel/usb/misc/ua101.c
diff -ru a/usb/misc/ua101.c b/usb/misc/ua101.c
--- a/usb/misc/ua101.c 2010-03-10 01:12:19.000000000 -0800
+++ b/usb/misc/ua101.c 2010-06-23 11:25:53.054884851 -0700
@@ -1,3 +1,5 @@
+#define __NO_VERSION__
+#include "usbaudio.inc"
#include "adriver.h"
#include "../../alsa-kernel/usb/misc/ua101.c"
EXPORT_NO_SYMBOLS;
--
Brad Figg brad.figg@canonical.com http://www.canonical.com
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-23 18:37 [PATCH 1/1] Daily snapshot not building on 2.6.32 Brad Figg @ 2010-06-24 6:27 ` Takashi Iwai 2010-06-24 14:56 ` Brad Figg 0 siblings, 1 reply; 13+ messages in thread From: Takashi Iwai @ 2010-06-24 6:27 UTC (permalink / raw) To: Brad Figg; +Cc: alsa-devel At Wed, 23 Jun 2010 11:37:16 -0700, Brad Figg wrote: > > I've had to apply the following patch to successfully build > the daily snapshot on 2.6.32. Without this patch I get: Which tarball? The latest one works fine for me. Takashi ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 6:27 ` Takashi Iwai @ 2010-06-24 14:56 ` Brad Figg 2010-06-24 15:02 ` Takashi Iwai 0 siblings, 1 reply; 13+ messages in thread From: Brad Figg @ 2010-06-24 14:56 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel On 06/23/2010 11:27 PM, Takashi Iwai wrote: > At Wed, 23 Jun 2010 11:37:16 -0700, > Brad Figg wrote: >> >> I've had to apply the following patch to successfully build >> the daily snapshot on 2.6.32. Without this patch I get: > > Which tarball? The latest one works fine for me. > > > Takashi Today's snapshot is giving me the exact same error. CC [M] /karmic/home/work/alsa/alsa-driver/usb/misc/ua101.o In file included from /karmic/home/work/alsa/alsa-driver/usb/misc/ua101.c:3: /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c: In function ‘alloc_stream_buffers’: /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1071: error: implicit declaration of function ‘usb_alloc_coherent’ /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1072: warning: assignment makes pointer from integer without a cast /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c: In function ‘free_stream_buffers’: /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1092: error: implicit declaration of function ‘usb_free_coherent’ /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c: In function ‘ua101_card_free’: /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1172: warning: unused variable ‘ua’ make[4]: *** [/karmic/home/work/alsa/alsa-driver/usb/misc/ua101.o] Error 1 make[3]: *** [/karmic/home/work/alsa/alsa-driver/usb/misc] Error 2 make[2]: *** [/karmic/home/work/alsa/alsa-driver/usb] Error 2 make[1]: *** [_module_/karmic/home/work/alsa/alsa-driver] Error 2 make[1]: Leaving directory `/usr/src/linux-headers-2.6.32-23-generic' Brad -- Brad Figg brad.figg@canonical.com http://www.canonical.com ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 14:56 ` Brad Figg @ 2010-06-24 15:02 ` Takashi Iwai 2010-06-24 15:27 ` Brad Figg 0 siblings, 1 reply; 13+ messages in thread From: Takashi Iwai @ 2010-06-24 15:02 UTC (permalink / raw) To: Brad Figg; +Cc: alsa-devel At Thu, 24 Jun 2010 07:56:35 -0700, Brad Figg wrote: > > On 06/23/2010 11:27 PM, Takashi Iwai wrote: > > At Wed, 23 Jun 2010 11:37:16 -0700, > > Brad Figg wrote: > >> > >> I've had to apply the following patch to successfully build > >> the daily snapshot on 2.6.32. Without this patch I get: > > > > Which tarball? The latest one works fine for me. > > > > > > Takashi > > Today's snapshot is giving me the exact same error. Did you get from the URL below, right? ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz Then check config.log whether usb_alloc_coherent() check worked. Takashi > > CC [M] /karmic/home/work/alsa/alsa-driver/usb/misc/ua101.o > In file included from /karmic/home/work/alsa/alsa-driver/usb/misc/ua101.c:3: > /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c: In function ‘alloc_stream_buffers’: > /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1071: error: implicit declaration of function ‘usb_alloc_coherent’ > /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1072: warning: assignment makes pointer from integer without a cast > /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c: In function ‘free_stream_buffers’: > /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1092: error: implicit declaration of function ‘usb_free_coherent’ > /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c: In function ‘ua101_card_free’: > /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1172: warning: unused variable ‘ua’ > make[4]: *** [/karmic/home/work/alsa/alsa-driver/usb/misc/ua101.o] Error 1 > make[3]: *** [/karmic/home/work/alsa/alsa-driver/usb/misc] Error 2 > make[2]: *** [/karmic/home/work/alsa/alsa-driver/usb] Error 2 > make[1]: *** [_module_/karmic/home/work/alsa/alsa-driver] Error 2 > make[1]: Leaving directory `/usr/src/linux-headers-2.6.32-23-generic' > > Brad > -- > Brad Figg brad.figg@canonical.com http://www.canonical.com > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 15:02 ` Takashi Iwai @ 2010-06-24 15:27 ` Brad Figg 2010-06-24 15:35 ` Takashi Iwai 0 siblings, 1 reply; 13+ messages in thread From: Brad Figg @ 2010-06-24 15:27 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel On 06/24/2010 08:02 AM, Takashi Iwai wrote: > At Thu, 24 Jun 2010 07:56:35 -0700, > Brad Figg wrote: >> >> On 06/23/2010 11:27 PM, Takashi Iwai wrote: >>> At Wed, 23 Jun 2010 11:37:16 -0700, >>> Brad Figg wrote: >>>> >>>> I've had to apply the following patch to successfully build >>>> the daily snapshot on 2.6.32. Without this patch I get: >>> >>> Which tarball? The latest one works fine for me. >>> >>> >>> Takashi >> >> Today's snapshot is giving me the exact same error. > > Did you get from the URL below, right? > > ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz > > Then check config.log whether usb_alloc_coherent() check worked. > > > Takashi > I'm pulling the snapshot from the correct location. However: checking usb_alloc_coherent... no Brad >> >> CC [M] /karmic/home/work/alsa/alsa-driver/usb/misc/ua101.o >> In file included from /karmic/home/work/alsa/alsa-driver/usb/misc/ua101.c:3: >> /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c: In function ‘alloc_stream_buffers’: >> /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1071: error: implicit declaration of function ‘usb_alloc_coherent’ >> /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1072: warning: assignment makes pointer from integer without a cast >> /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c: In function ‘free_stream_buffers’: >> /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1092: error: implicit declaration of function ‘usb_free_coherent’ >> /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c: In function ‘ua101_card_free’: >> /karmic/home/work/alsa/alsa-driver/usb/misc/../../alsa-kernel/usb/misc/ua101.c:1172: warning: unused variable ‘ua’ >> make[4]: *** [/karmic/home/work/alsa/alsa-driver/usb/misc/ua101.o] Error 1 >> make[3]: *** [/karmic/home/work/alsa/alsa-driver/usb/misc] Error 2 >> make[2]: *** [/karmic/home/work/alsa/alsa-driver/usb] Error 2 >> make[1]: *** [_module_/karmic/home/work/alsa/alsa-driver] Error 2 >> make[1]: Leaving directory `/usr/src/linux-headers-2.6.32-23-generic' >> >> Brad >> -- >> Brad Figg brad.figg@canonical.com http://www.canonical.com >> -- Brad Figg brad.figg@canonical.com http://www.canonical.com _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 15:27 ` Brad Figg @ 2010-06-24 15:35 ` Takashi Iwai 2010-06-24 15:37 ` Brad Figg 0 siblings, 1 reply; 13+ messages in thread From: Takashi Iwai @ 2010-06-24 15:35 UTC (permalink / raw) To: Brad Figg; +Cc: alsa-devel At Thu, 24 Jun 2010 08:27:37 -0700, Brad Figg wrote: > > On 06/24/2010 08:02 AM, Takashi Iwai wrote: > > At Thu, 24 Jun 2010 07:56:35 -0700, > > Brad Figg wrote: > >> > >> On 06/23/2010 11:27 PM, Takashi Iwai wrote: > >>> At Wed, 23 Jun 2010 11:37:16 -0700, > >>> Brad Figg wrote: > >>>> > >>>> I've had to apply the following patch to successfully build > >>>> the daily snapshot on 2.6.32. Without this patch I get: > >>> > >>> Which tarball? The latest one works fine for me. > >>> > >>> > >>> Takashi > >> > >> Today's snapshot is giving me the exact same error. > > > > Did you get from the URL below, right? > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz > > > > Then check config.log whether usb_alloc_coherent() check worked. > > > > > > Takashi > > > > I'm pulling the snapshot from the correct location. However: > checking usb_alloc_coherent... no That's correct. Then it must have #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT in include/config.h, and incldue/adriver.h should define a wrapper for the function. Please check it. Takashi ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 15:35 ` Takashi Iwai @ 2010-06-24 15:37 ` Brad Figg 2010-06-24 15:40 ` Takashi Iwai 0 siblings, 1 reply; 13+ messages in thread From: Brad Figg @ 2010-06-24 15:37 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel On 06/24/2010 08:35 AM, Takashi Iwai wrote: > At Thu, 24 Jun 2010 08:27:37 -0700, > Brad Figg wrote: >> >> On 06/24/2010 08:02 AM, Takashi Iwai wrote: >>> At Thu, 24 Jun 2010 07:56:35 -0700, >>> Brad Figg wrote: >>>> >>>> On 06/23/2010 11:27 PM, Takashi Iwai wrote: >>>>> At Wed, 23 Jun 2010 11:37:16 -0700, >>>>> Brad Figg wrote: >>>>>> >>>>>> I've had to apply the following patch to successfully build >>>>>> the daily snapshot on 2.6.32. Without this patch I get: >>>>> >>>>> Which tarball? The latest one works fine for me. >>>>> >>>>> >>>>> Takashi >>>> >>>> Today's snapshot is giving me the exact same error. >>> >>> Did you get from the URL below, right? >>> >>> ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz >>> >>> Then check config.log whether usb_alloc_coherent() check worked. >>> >>> >>> Takashi >>> >> >> I'm pulling the snapshot from the correct location. However: >> checking usb_alloc_coherent... no > > That's correct. Then it must have > #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT > in include/config.h, and incldue/adriver.h should define a wrapper for > the function. Please check it. > > > Takashi include/config.h: /* #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT */ include/adriver.h: #ifndef CONFIG_SND_HAVE_USB_ALLOC_COHERENT #define usb_alloc_coherent usb_buffer_alloc #define usb_free_coherent usb_buffer_free #endif -- Brad Figg brad.figg@canonical.com http://www.canonical.com ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 15:37 ` Brad Figg @ 2010-06-24 15:40 ` Takashi Iwai 2010-06-24 15:50 ` Brad Figg 2010-06-24 18:07 ` Brad Figg 0 siblings, 2 replies; 13+ messages in thread From: Takashi Iwai @ 2010-06-24 15:40 UTC (permalink / raw) To: Brad Figg; +Cc: alsa-devel At Thu, 24 Jun 2010 08:37:40 -0700, Brad Figg wrote: > > On 06/24/2010 08:35 AM, Takashi Iwai wrote: > > At Thu, 24 Jun 2010 08:27:37 -0700, > > Brad Figg wrote: > >> > >> On 06/24/2010 08:02 AM, Takashi Iwai wrote: > >>> At Thu, 24 Jun 2010 07:56:35 -0700, > >>> Brad Figg wrote: > >>>> > >>>> On 06/23/2010 11:27 PM, Takashi Iwai wrote: > >>>>> At Wed, 23 Jun 2010 11:37:16 -0700, > >>>>> Brad Figg wrote: > >>>>>> > >>>>>> I've had to apply the following patch to successfully build > >>>>>> the daily snapshot on 2.6.32. Without this patch I get: > >>>>> > >>>>> Which tarball? The latest one works fine for me. > >>>>> > >>>>> > >>>>> Takashi > >>>> > >>>> Today's snapshot is giving me the exact same error. > >>> > >>> Did you get from the URL below, right? > >>> > >>> ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz > >>> > >>> Then check config.log whether usb_alloc_coherent() check worked. > >>> > >>> > >>> Takashi > >>> > >> > >> I'm pulling the snapshot from the correct location. However: > >> checking usb_alloc_coherent... no > > > > That's correct. Then it must have > > #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT > > in include/config.h, and incldue/adriver.h should define a wrapper for > > the function. Please check it. > > > > > > Takashi > > include/config.h: > > /* #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT */ > > > > include/adriver.h: > > #ifndef CONFIG_SND_HAVE_USB_ALLOC_COHERENT > #define usb_alloc_coherent usb_buffer_alloc > #define usb_free_coherent usb_buffer_free > #endif Check whether the code patch there reaches while compiling ua101.c. Takashi ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 15:40 ` Takashi Iwai @ 2010-06-24 15:50 ` Brad Figg 2010-06-24 18:42 ` Takashi Iwai 2010-06-24 18:07 ` Brad Figg 1 sibling, 1 reply; 13+ messages in thread From: Brad Figg @ 2010-06-24 15:50 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel On 06/24/2010 08:40 AM, Takashi Iwai wrote: > At Thu, 24 Jun 2010 08:37:40 -0700, > Brad Figg wrote: >> >> On 06/24/2010 08:35 AM, Takashi Iwai wrote: >>> At Thu, 24 Jun 2010 08:27:37 -0700, >>> Brad Figg wrote: >>>> >>>> On 06/24/2010 08:02 AM, Takashi Iwai wrote: >>>>> At Thu, 24 Jun 2010 07:56:35 -0700, >>>>> Brad Figg wrote: >>>>>> >>>>>> On 06/23/2010 11:27 PM, Takashi Iwai wrote: >>>>>>> At Wed, 23 Jun 2010 11:37:16 -0700, >>>>>>> Brad Figg wrote: >>>>>>>> >>>>>>>> I've had to apply the following patch to successfully build >>>>>>>> the daily snapshot on 2.6.32. Without this patch I get: >>>>>>> >>>>>>> Which tarball? The latest one works fine for me. >>>>>>> >>>>>>> >>>>>>> Takashi >>>>>> >>>>>> Today's snapshot is giving me the exact same error. >>>>> >>>>> Did you get from the URL below, right? >>>>> >>>>> ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz >>>>> >>>>> Then check config.log whether usb_alloc_coherent() check worked. >>>>> >>>>> >>>>> Takashi >>>>> >>>> >>>> I'm pulling the snapshot from the correct location. However: >>>> checking usb_alloc_coherent... no >>> >>> That's correct. Then it must have >>> #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT >>> in include/config.h, and incldue/adriver.h should define a wrapper for >>> the function. Please check it. >>> >>> >>> Takashi >> >> include/config.h: >> >> /* #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT */ >> >> >> >> include/adriver.h: >> >> #ifndef CONFIG_SND_HAVE_USB_ALLOC_COHERENT >> #define usb_alloc_coherent usb_buffer_alloc >> #define usb_free_coherent usb_buffer_free >> #endif > > Check whether the code patch there reaches while compiling ua101.c. > > > Takashi It does not reach that when compiling ua101.c. The reason for the patch in the original email was to pick up the SND_NEED_USB_WRAPPER define when compiling that file. Brad -- Brad Figg brad.figg@canonical.com http://www.canonical.com ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 15:50 ` Brad Figg @ 2010-06-24 18:42 ` Takashi Iwai 0 siblings, 0 replies; 13+ messages in thread From: Takashi Iwai @ 2010-06-24 18:42 UTC (permalink / raw) To: Brad Figg; +Cc: alsa-devel At Thu, 24 Jun 2010 08:50:48 -0700, Brad Figg wrote: > > On 06/24/2010 08:40 AM, Takashi Iwai wrote: > > At Thu, 24 Jun 2010 08:37:40 -0700, > > Brad Figg wrote: > >> > >> On 06/24/2010 08:35 AM, Takashi Iwai wrote: > >>> At Thu, 24 Jun 2010 08:27:37 -0700, > >>> Brad Figg wrote: > >>>> > >>>> On 06/24/2010 08:02 AM, Takashi Iwai wrote: > >>>>> At Thu, 24 Jun 2010 07:56:35 -0700, > >>>>> Brad Figg wrote: > >>>>>> > >>>>>> On 06/23/2010 11:27 PM, Takashi Iwai wrote: > >>>>>>> At Wed, 23 Jun 2010 11:37:16 -0700, > >>>>>>> Brad Figg wrote: > >>>>>>>> > >>>>>>>> I've had to apply the following patch to successfully build > >>>>>>>> the daily snapshot on 2.6.32. Without this patch I get: > >>>>>>> > >>>>>>> Which tarball? The latest one works fine for me. > >>>>>>> > >>>>>>> > >>>>>>> Takashi > >>>>>> > >>>>>> Today's snapshot is giving me the exact same error. > >>>>> > >>>>> Did you get from the URL below, right? > >>>>> > >>>>> ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz > >>>>> > >>>>> Then check config.log whether usb_alloc_coherent() check worked. > >>>>> > >>>>> > >>>>> Takashi > >>>>> > >>>> > >>>> I'm pulling the snapshot from the correct location. However: > >>>> checking usb_alloc_coherent... no > >>> > >>> That's correct. Then it must have > >>> #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT > >>> in include/config.h, and incldue/adriver.h should define a wrapper for > >>> the function. Please check it. > >>> > >>> > >>> Takashi > >> > >> include/config.h: > >> > >> /* #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT */ > >> > >> > >> > >> include/adriver.h: > >> > >> #ifndef CONFIG_SND_HAVE_USB_ALLOC_COHERENT > >> #define usb_alloc_coherent usb_buffer_alloc > >> #define usb_free_coherent usb_buffer_free > >> #endif > > > > Check whether the code patch there reaches while compiling ua101.c. > > > > > > Takashi > > It does not reach that when compiling ua101.c. The reason for the patch in > the original email was to pick up the SND_NEED_USB_WRAPPER define when > compiling that file. Ah, right. It should include "../usbaudio.inc" instead of "adriver.h". I fixed this now. thanks, Takashi ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 15:40 ` Takashi Iwai 2010-06-24 15:50 ` Brad Figg @ 2010-06-24 18:07 ` Brad Figg 2010-06-24 18:43 ` Takashi Iwai 1 sibling, 1 reply; 13+ messages in thread From: Brad Figg @ 2010-06-24 18:07 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel On 06/24/2010 08:40 AM, Takashi Iwai wrote: > At Thu, 24 Jun 2010 08:37:40 -0700, > Brad Figg wrote: >> >> On 06/24/2010 08:35 AM, Takashi Iwai wrote: >>> At Thu, 24 Jun 2010 08:27:37 -0700, >>> Brad Figg wrote: >>>> >>>> On 06/24/2010 08:02 AM, Takashi Iwai wrote: >>>>> At Thu, 24 Jun 2010 07:56:35 -0700, >>>>> Brad Figg wrote: >>>>>> >>>>>> On 06/23/2010 11:27 PM, Takashi Iwai wrote: >>>>>>> At Wed, 23 Jun 2010 11:37:16 -0700, >>>>>>> Brad Figg wrote: >>>>>>>> >>>>>>>> I've had to apply the following patch to successfully build >>>>>>>> the daily snapshot on 2.6.32. Without this patch I get: >>>>>>> >>>>>>> Which tarball? The latest one works fine for me. >>>>>>> >>>>>>> >>>>>>> Takashi >>>>>> >>>>>> Today's snapshot is giving me the exact same error. >>>>> >>>>> Did you get from the URL below, right? >>>>> >>>>> ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz >>>>> >>>>> Then check config.log whether usb_alloc_coherent() check worked. >>>>> >>>>> >>>>> Takashi >>>>> >>>> >>>> I'm pulling the snapshot from the correct location. However: >>>> checking usb_alloc_coherent... no >>> >>> That's correct. Then it must have >>> #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT >>> in include/config.h, and incldue/adriver.h should define a wrapper for >>> the function. Please check it. >>> >>> >>> Takashi >> >> include/config.h: >> >> /* #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT */ >> >> >> >> include/adriver.h: >> >> #ifndef CONFIG_SND_HAVE_USB_ALLOC_COHERENT >> #define usb_alloc_coherent usb_buffer_alloc >> #define usb_free_coherent usb_buffer_free >> #endif > > Check whether the code patch there reaches while compiling ua101.c. > > > Takashi And, by the way, I'm getting this error when trying to build today's snapshot on 2.6.35. CC [M] /home/work/alsa/alsa-driver/acore/pcm_native.o /home/work/alsa/alsa-driver/acore/pcm_native.c: In function ‘snd_pcm_hw_params’: /home/work/alsa/alsa-driver/acore/pcm_native.c:468: error: implicit declaration of function ‘pm_qos_remove_requirement’ /home/work/alsa/alsa-driver/acore/pcm_native.c:471: error: implicit declaration of function ‘pm_qos_add_requirement’ make[3]: *** [/home/work/alsa/alsa-driver/acore/pcm_native.o] Error 1 make[2]: *** [/home/work/alsa/alsa-driver/acore] Error 2 make[1]: *** [_module_/home/work/alsa/alsa-driver] Error 2 Which I've not been able to figure out any work around after an hour or more of working on it. Brad -- Brad Figg brad.figg@canonical.com http://www.canonical.com ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 18:07 ` Brad Figg @ 2010-06-24 18:43 ` Takashi Iwai 2010-06-24 18:47 ` Brad Figg 0 siblings, 1 reply; 13+ messages in thread From: Takashi Iwai @ 2010-06-24 18:43 UTC (permalink / raw) To: Brad Figg; +Cc: alsa-devel At Thu, 24 Jun 2010 11:07:27 -0700, Brad Figg wrote: > > On 06/24/2010 08:40 AM, Takashi Iwai wrote: > > At Thu, 24 Jun 2010 08:37:40 -0700, > > Brad Figg wrote: > >> > >> On 06/24/2010 08:35 AM, Takashi Iwai wrote: > >>> At Thu, 24 Jun 2010 08:27:37 -0700, > >>> Brad Figg wrote: > >>>> > >>>> On 06/24/2010 08:02 AM, Takashi Iwai wrote: > >>>>> At Thu, 24 Jun 2010 07:56:35 -0700, > >>>>> Brad Figg wrote: > >>>>>> > >>>>>> On 06/23/2010 11:27 PM, Takashi Iwai wrote: > >>>>>>> At Wed, 23 Jun 2010 11:37:16 -0700, > >>>>>>> Brad Figg wrote: > >>>>>>>> > >>>>>>>> I've had to apply the following patch to successfully build > >>>>>>>> the daily snapshot on 2.6.32. Without this patch I get: > >>>>>>> > >>>>>>> Which tarball? The latest one works fine for me. > >>>>>>> > >>>>>>> > >>>>>>> Takashi > >>>>>> > >>>>>> Today's snapshot is giving me the exact same error. > >>>>> > >>>>> Did you get from the URL below, right? > >>>>> > >>>>> ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz > >>>>> > >>>>> Then check config.log whether usb_alloc_coherent() check worked. > >>>>> > >>>>> > >>>>> Takashi > >>>>> > >>>> > >>>> I'm pulling the snapshot from the correct location. However: > >>>> checking usb_alloc_coherent... no > >>> > >>> That's correct. Then it must have > >>> #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT > >>> in include/config.h, and incldue/adriver.h should define a wrapper for > >>> the function. Please check it. > >>> > >>> > >>> Takashi > >> > >> include/config.h: > >> > >> /* #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT */ > >> > >> > >> > >> include/adriver.h: > >> > >> #ifndef CONFIG_SND_HAVE_USB_ALLOC_COHERENT > >> #define usb_alloc_coherent usb_buffer_alloc > >> #define usb_free_coherent usb_buffer_free > >> #endif > > > > Check whether the code patch there reaches while compiling ua101.c. > > > > > > Takashi > > And, by the way, I'm getting this error when trying to build today's snapshot > on 2.6.35. > > CC [M] /home/work/alsa/alsa-driver/acore/pcm_native.o > /home/work/alsa/alsa-driver/acore/pcm_native.c: In function ‘snd_pcm_hw_params’: > /home/work/alsa/alsa-driver/acore/pcm_native.c:468: error: implicit declaration of function ‘pm_qos_remove_requirement’ > /home/work/alsa/alsa-driver/acore/pcm_native.c:471: error: implicit declaration of function ‘pm_qos_add_requirement’ > make[3]: *** [/home/work/alsa/alsa-driver/acore/pcm_native.o] Error 1 > make[2]: *** [/home/work/alsa/alsa-driver/acore] Error 2 > make[1]: *** [_module_/home/work/alsa/alsa-driver] Error 2 > > Which I've not been able to figure out any work around after an hour or > more of working on it. Likely the pm-qos API was changed once again. In general, the latest kernel is not targeted for alsa-driver external builds. Use sound git tree instead. I'll fix it after I back from my vacation (about a week). thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/1] Daily snapshot not building on 2.6.32 2010-06-24 18:43 ` Takashi Iwai @ 2010-06-24 18:47 ` Brad Figg 0 siblings, 0 replies; 13+ messages in thread From: Brad Figg @ 2010-06-24 18:47 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel On 06/24/2010 11:43 AM, Takashi Iwai wrote: > At Thu, 24 Jun 2010 11:07:27 -0700, > Brad Figg wrote: >> >> On 06/24/2010 08:40 AM, Takashi Iwai wrote: >>> At Thu, 24 Jun 2010 08:37:40 -0700, >>> Brad Figg wrote: >>>> >>>> On 06/24/2010 08:35 AM, Takashi Iwai wrote: >>>>> At Thu, 24 Jun 2010 08:27:37 -0700, >>>>> Brad Figg wrote: >>>>>> >>>>>> On 06/24/2010 08:02 AM, Takashi Iwai wrote: >>>>>>> At Thu, 24 Jun 2010 07:56:35 -0700, >>>>>>> Brad Figg wrote: >>>>>>>> >>>>>>>> On 06/23/2010 11:27 PM, Takashi Iwai wrote: >>>>>>>>> At Wed, 23 Jun 2010 11:37:16 -0700, >>>>>>>>> Brad Figg wrote: >>>>>>>>>> >>>>>>>>>> I've had to apply the following patch to successfully build >>>>>>>>>> the daily snapshot on 2.6.32. Without this patch I get: >>>>>>>>> >>>>>>>>> Which tarball? The latest one works fine for me. >>>>>>>>> >>>>>>>>> >>>>>>>>> Takashi >>>>>>>> >>>>>>>> Today's snapshot is giving me the exact same error. >>>>>>> >>>>>>> Did you get from the URL below, right? >>>>>>> >>>>>>> ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz >>>>>>> >>>>>>> Then check config.log whether usb_alloc_coherent() check worked. >>>>>>> >>>>>>> >>>>>>> Takashi >>>>>>> >>>>>> >>>>>> I'm pulling the snapshot from the correct location. However: >>>>>> checking usb_alloc_coherent... no >>>>> >>>>> That's correct. Then it must have >>>>> #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT >>>>> in include/config.h, and incldue/adriver.h should define a wrapper for >>>>> the function. Please check it. >>>>> >>>>> >>>>> Takashi >>>> >>>> include/config.h: >>>> >>>> /* #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT */ >>>> >>>> >>>> >>>> include/adriver.h: >>>> >>>> #ifndef CONFIG_SND_HAVE_USB_ALLOC_COHERENT >>>> #define usb_alloc_coherent usb_buffer_alloc >>>> #define usb_free_coherent usb_buffer_free >>>> #endif >>> >>> Check whether the code patch there reaches while compiling ua101.c. >>> >>> >>> Takashi >> >> And, by the way, I'm getting this error when trying to build today's snapshot >> on 2.6.35. >> >> CC [M] /home/work/alsa/alsa-driver/acore/pcm_native.o >> /home/work/alsa/alsa-driver/acore/pcm_native.c: In function ‘snd_pcm_hw_params’: >> /home/work/alsa/alsa-driver/acore/pcm_native.c:468: error: implicit declaration of function ‘pm_qos_remove_requirement’ >> /home/work/alsa/alsa-driver/acore/pcm_native.c:471: error: implicit declaration of function ‘pm_qos_add_requirement’ >> make[3]: *** [/home/work/alsa/alsa-driver/acore/pcm_native.o] Error 1 >> make[2]: *** [/home/work/alsa/alsa-driver/acore] Error 2 >> make[1]: *** [_module_/home/work/alsa/alsa-driver] Error 2 >> >> Which I've not been able to figure out any work around after an hour or >> more of working on it. > > Likely the pm-qos API was changed once again. > In general, the latest kernel is not targeted for alsa-driver external > builds. Use sound git tree instead. > > I'll fix it after I back from my vacation (about a week). > > > thanks, > > Takashi Thanks. -- Brad Figg brad.figg@canonical.com http://www.canonical.com _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2010-06-24 18:48 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-06-23 18:37 [PATCH 1/1] Daily snapshot not building on 2.6.32 Brad Figg 2010-06-24 6:27 ` Takashi Iwai 2010-06-24 14:56 ` Brad Figg 2010-06-24 15:02 ` Takashi Iwai 2010-06-24 15:27 ` Brad Figg 2010-06-24 15:35 ` Takashi Iwai 2010-06-24 15:37 ` Brad Figg 2010-06-24 15:40 ` Takashi Iwai 2010-06-24 15:50 ` Brad Figg 2010-06-24 18:42 ` Takashi Iwai 2010-06-24 18:07 ` Brad Figg 2010-06-24 18:43 ` Takashi Iwai 2010-06-24 18:47 ` Brad Figg
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.