From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH]libxc: fix a Segmentation fault
Date: Tue, 29 Jun 2010 08:40:21 +0800 [thread overview]
Message-ID: <4C2940F5.5030603@cn.fujitsu.com> (raw)
In-Reply-To: <19496.50624.967390.571291@mariner.uk.xensource.com>
On 06/28/2010 11:54 PM, Ian Jackson wrote:
> Yang Hongyang writes ("[Xen-devel] [PATCH]libxc: fix a Segmentation fault"):
>> # xl list
>> xc: error: Could not obtain handle on privileged command interface (2 = No such file or directory): Internal error
>> Segmentation fault
>>
>> This is because xc free the logger which xl created.
>
> Well spotted. You're right about the cause, but your fix is not
> correct. The correct fix is that xc_interface_open's error path
> should free error_handler_tofree rather than error_handler. So there
> is no need to add another variable. I will apply that fix.
>
OK,Thanks Ian.
> Thanks,
> Ian.
>
>
--
Regards
Yang Hongyang
prev parent reply other threads:[~2010-06-29 0:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 6:45 [PATCH]libxc: fix a Segmentation fault Yang Hongyang
2010-06-28 15:54 ` Ian Jackson
2010-06-29 0:40 ` Yang Hongyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2940F5.5030603@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.