Re: [PATCH] pyGrub: Fix default when out of range

[Michal Novotny <minovotn@redhat.com>]

On 06/29/2010 03:54 PM, Ian Jackson wrote:
> Michal Novotny writes ("[Xen-devel] [PATCH] pyGrub: Fix default when out of range"):
>    
>> this is the patch to fix pyGrub default value when it's being set out of
>> range. This patch makes the quiet and interactive mode select the same
>> default image when the default value for boot entry is out of range,
>> i.e. when the guest is having wrong configuration in it's boot loader
>> (like 3 entries with default mistakenly set to 10 etc).
>>      
> I'm not sure this is right.  What does grub proper do with invalid
> defaults ?  Is it really correct to blunder on and just use the first
> one as a default ?
>
> Sorry to quibble.
>
> Ian.
>    

Hi Ian,
I did try it using the real (bare-metal) grub 0.97 (in RHEL-5) to set 
the default out of range and it was set to the first entry so it matches 
the bare-metal grub behavior now. So the quiet mode was having it right 
all the time but interactive mode didn't so this is basically fix for 
interactive mode of pygrub.

Michal

-- 
Michal Novotny<minovotn@redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat