From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
KVM list <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linuxppc-dev
<linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH 0/2] Faster MMU lookups for Book3s v3
Date: Thu, 01 Jul 2010 08:40:30 +0000 [thread overview]
Message-ID: <4C2C547E.7010404@redhat.com> (raw)
In-Reply-To: <7F9C2F52-3E95-4A22-B973-DACEBC95E5F4-l3A5Bk7waGM@public.gmane.org>
On 07/01/2010 11:18 AM, Alexander Graf wrote:
>
> How does dirty bitmap flushing work on x86 atm? I loop through all mapped pages and flush the ones that match the range of the region I need to flush. But wouldn't it be a lot more efficient to have an hlist in the memslot and loop through that when I need to flush that memslot?
>
x86 loops through the reverse-map link list rooted at the memory slot.
The linked list links all sptes for a single hva.
So, it's like you describe, except it's an array of lists instead of a
single list. We need per-page rmap lists to be able to remove a page's
sptes in response to an mmu notifier callback, and to be able to write
protect a guest page if it's used as a page table.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
KVM list <kvm@vger.kernel.org>,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 0/2] Faster MMU lookups for Book3s v3
Date: Thu, 01 Jul 2010 11:40:30 +0300 [thread overview]
Message-ID: <4C2C547E.7010404@redhat.com> (raw)
In-Reply-To: <7F9C2F52-3E95-4A22-B973-DACEBC95E5F4@suse.de>
On 07/01/2010 11:18 AM, Alexander Graf wrote:
>
> How does dirty bitmap flushing work on x86 atm? I loop through all mapped pages and flush the ones that match the range of the region I need to flush. But wouldn't it be a lot more efficient to have an hlist in the memslot and loop through that when I need to flush that memslot?
>
x86 loops through the reverse-map link list rooted at the memory slot.
The linked list links all sptes for a single hva.
So, it's like you describe, except it's an array of lists instead of a
single list. We need per-page rmap lists to be able to remove a page's
sptes in response to an mmu notifier callback, and to be able to write
protect a guest page if it's used as a page table.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
KVM list <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linuxppc-dev
<linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH 0/2] Faster MMU lookups for Book3s v3
Date: Thu, 01 Jul 2010 11:40:30 +0300 [thread overview]
Message-ID: <4C2C547E.7010404@redhat.com> (raw)
In-Reply-To: <7F9C2F52-3E95-4A22-B973-DACEBC95E5F4-l3A5Bk7waGM@public.gmane.org>
On 07/01/2010 11:18 AM, Alexander Graf wrote:
>
> How does dirty bitmap flushing work on x86 atm? I loop through all mapped pages and flush the ones that match the range of the region I need to flush. But wouldn't it be a lot more efficient to have an hlist in the memslot and loop through that when I need to flush that memslot?
>
x86 loops through the reverse-map link list rooted at the memory slot.
The linked list links all sptes for a single hva.
So, it's like you describe, except it's an array of lists instead of a
single list. We need per-page rmap lists to be able to remove a page's
sptes in response to an mmu notifier callback, and to be able to write
protect a guest page if it's used as a page table.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-07-01 8:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 13:18 [PATCH 0/2] Faster MMU lookups for Book3s v3 Alexander Graf
2010-06-30 13:18 ` Alexander Graf
2010-06-30 13:18 ` Alexander Graf
[not found] ` <1277903926-12786-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-06-30 13:18 ` [PATCH 1/2] KVM: PPC: Add generic hpte management functions Alexander Graf
2010-06-30 13:18 ` Alexander Graf
2010-06-30 13:18 ` Alexander Graf
2010-06-30 13:18 ` [PATCH 2/2] KVM: PPC: Make use of hash based Shadow MMU Alexander Graf
2010-06-30 13:18 ` Alexander Graf
2010-06-30 13:18 ` Alexander Graf
2010-07-01 7:29 ` [PATCH 0/2] Faster MMU lookups for Book3s v3 Avi Kivity
2010-07-01 7:29 ` Avi Kivity
2010-07-01 7:29 ` Avi Kivity
[not found] ` <4C2C43C0.4000400-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-07-01 8:18 ` Alexander Graf
2010-07-01 8:18 ` Alexander Graf
2010-07-01 8:18 ` Alexander Graf
[not found] ` <7F9C2F52-3E95-4A22-B973-DACEBC95E5F4-l3A5Bk7waGM@public.gmane.org>
2010-07-01 8:40 ` Avi Kivity [this message]
2010-07-01 8:40 ` Avi Kivity
2010-07-01 8:40 ` Avi Kivity
2010-07-01 10:00 ` Alexander Graf
2010-07-01 10:00 ` Alexander Graf
2010-07-01 10:00 ` Alexander Graf
2010-07-01 11:14 ` Avi Kivity
2010-07-01 11:14 ` Avi Kivity
2010-07-01 11:14 ` Avi Kivity
2010-07-01 12:28 ` Alexander Graf
2010-07-01 12:28 ` Alexander Graf
2010-07-01 12:28 ` Alexander Graf
[not found] ` <4C2C89D6.3090401-l3A5Bk7waGM@public.gmane.org>
2010-07-01 12:43 ` Avi Kivity
2010-07-01 12:43 ` Avi Kivity
2010-07-01 12:43 ` Avi Kivity
[not found] ` <4C2C8D8A.7080103-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-07-01 12:52 ` Alexander Graf
2010-07-01 12:52 ` Alexander Graf
2010-07-01 12:52 ` Alexander Graf
[not found] ` <4C2C8FA8.1030702-l3A5Bk7waGM@public.gmane.org>
2010-07-01 13:42 ` Avi Kivity
2010-07-01 13:42 ` Avi Kivity
2010-07-01 13:42 ` Avi Kivity
2010-07-02 2:54 ` Benjamin Herrenschmidt
2010-07-02 2:54 ` Benjamin Herrenschmidt
2010-07-02 2:50 ` Benjamin Herrenschmidt
2010-07-02 2:50 ` Benjamin Herrenschmidt
2010-07-02 2:50 ` Benjamin Herrenschmidt
2010-07-01 15:40 ` Marcelo Tosatti
2010-07-01 15:40 ` Marcelo Tosatti
2010-07-01 15:40 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2C547E.7010404@redhat.com \
--to=avi@redhat.com \
--cc=agraf-l3A5Bk7waGM@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.