From: George Dunlap <George.Dunlap@eu.citrix.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <Keir.Fraser@eu.citrix.com>
Subject: Re: Re: [PATCH 2/6] trace: fix T_INFO_FIRST_OFFSET
Date: Thu, 01 Jul 2010 10:53:33 +0100 [thread overview]
Message-ID: <4C2C659D.9080007@eu.citrix.com> (raw)
In-Reply-To: <4C2C80E402000078000090AD@vpn.id2.novell.com>
On 01/07/10 10:49, Jan Beulich wrote:
>>>> On 30.06.10 at 18:12, George Dunlap<George.Dunlap@eu.citrix.com> wrote:
>> + offset_in_bytes = ((char *)&((struct t_info *)(NULL))->mfn_offset[NR_CPUS]) - (char *)(NULL);
>
> Why can't this just be offsetof(struct t_info, mfn_offset[NR_CPUS])?
Ah... forgot about that one. Thanks, I'll modify that in my patch series.
-George
prev parent reply other threads:[~2010-07-01 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 15:32 [PATCH 2/6] trace: fix T_INFO_FIRST_OFFSET Jan Beulich
2010-06-30 14:52 ` George Dunlap
2010-06-30 15:15 ` Jan Beulich
2010-06-30 15:28 ` George Dunlap
2010-06-30 16:10 ` George Dunlap
2010-06-30 16:12 ` George Dunlap
2010-06-30 17:14 ` Keir Fraser
2010-06-30 18:12 ` George Dunlap
2010-07-01 9:50 ` Jan Beulich
2010-07-01 9:49 ` Jan Beulich
2010-07-01 9:53 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2C659D.9080007@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=JBeulich@novell.com \
--cc=Keir.Fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.