[PATCH] Voicecall gaps.

[PATCH] Voicecall gaps.

[Pekka.Pessi]

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

From: Pekka Pessi <Pekka.Pessi@nokia.com>

Missing voicecall functionality pieces from tp-ring point-of-view.
---
 TODO |   27 +++++++++++++++++++++++++++
 1 files changed, 27 insertions(+), 0 deletions(-)

diff --git a/TODO b/TODO
index 470d4a6..e6ef20d 100644
--- a/TODO
+++ b/TODO
@@ -265,6 +265,33 @@ Supplementary Services
   Complexity: C8
 
 
+Voicecall
+=========
+
+- Supplementary service notifications for remote party putting call on hold
+  or retrieving the call or joining call to a multiparty conference.
+
+  Priority: Medium
+  Complexity: C1
+  Owner: Pekka Pessi <pekka.pessi@nokia.com>
+
+- Dial strings. Include CLIR prefixes and 2nd stage dial strings in call history.
+
+  Priority: Medium
+  Complexity: C2
+
+- Start DTMF, Stop DTMF, feedback of sent DTMF tones.
+
+  Priority: Medium
+  Complexity: C2
+
+- Add atom for assisting in local supervisory tone generation when modem
+  does include tones in media streams.
+
+  Priority: Medium
+  Complexity: C2
+
+
 Miscellaneous
 =============
 
-- 
1.7.0.4

Re: [PATCH] Voicecall gaps.

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1903 bytes --]

On 06/30/2010 08:01 AM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi<Pekka.Pessi@nokia.com>
>
> Missing voicecall functionality pieces from tp-ring point-of-view.
> ---
>   TODO |   27 +++++++++++++++++++++++++++
>   1 files changed, 27 insertions(+), 0 deletions(-)
>
> diff --git a/TODO b/TODO
> index 470d4a6..e6ef20d 100644
> --- a/TODO
> +++ b/TODO
> @@ -265,6 +265,33 @@ Supplementary Services
>     Complexity: C8
>
>
> +Voicecall
> +=========
> +
> +- Supplementary service notifications for remote party putting call on hold
> +  or retrieving the call or joining call to a multiparty conference.
> +
> +  Priority: Medium
> +  Complexity: C1
> +  Owner: Pekka Pessi<pekka.pessi@nokia.com>

Is this in any way related to the present ssn atom?  If it is, then you 
might want to mention this in a bit more detail here.  And are you sure 
this is a C1 task?  Considering the API changes involved, I doubt this 
is a C1 task.

> +
> +- Dial strings. Include CLIR prefixes and 2nd stage dial strings in call history.
> +
> +  Priority: Medium
> +  Complexity: C2
> +
> +- Start DTMF, Stop DTMF, feedback of sent DTMF tones.
> +
> +  Priority: Medium
> +  Complexity: C2

In general if a task is of lower complexity (e.g. C1 or C2) I'd really 
like a short description of the proposed solution in the task overview. 
  In the above two cases I'm really curious how you will manage to do 
this, in particular since AT commands do not support starting / stopping 
DTMF tones.

Please include a short strategy description or increase the complexity.

> +
> +- Add atom for assisting in local supervisory tone generation when modem
> +  does include tones in media streams.
> +
> +  Priority: Medium
> +  Complexity: C2
> +
> +

Please hold off on this one, I'm really not convinced this belongs in 
oFono just yet.

Regards,
-Denis

[PATCH] Voicecall gaps.

[Pekka.Pessi]

[-- Attachment #1: Type: text/plain, Size: 2124 bytes --]

From: Pekka Pessi <Pekka.Pessi@nokia.com>

Missing voicecall functionality pieces from tp-ring point-of-view.
---
 TODO                         |   27 +++++++++++++++++++++++++++
 doc/voicecallmanager-api.txt |    8 ++++----
 2 files changed, 31 insertions(+), 4 deletions(-)

diff --git a/TODO b/TODO
index 470d4a6..fc539a7 100644
--- a/TODO
+++ b/TODO
@@ -265,6 +265,33 @@ Supplementary Services
   Complexity: C8
 
 
+Voicecall
+=========
+
+- Supplementary service notifications on remote party actions:
+  - call has been put on hold (+CSSU: 2)
+  - call has been retrieved (+CSSU: 3), and
+  - joining call to a multiparty conference (+CSSU: 4)
+
+  Priority: Medium
+  Complexity: C1
+  Owner: Pekka Pessi <pekka.pessi@nokia.com>
+
+- Dial strings. Include CLIR prefixes and 2nd stage dial strings in the
+  DialString call property. Add dialstring accessor method to C API.
+
+  Priority: Medium
+
+- Provide feedback of sent DTMF tones. Emit SendingTones signal if modem can
+  provide approximate starting and stopping times for DTMF tones. Signal
+  argument contains a string of DTMF tones to be sent, or empty string when
+  all tones has been sent.
+
+  Priority: Medium
+  Complexity: C2
+  Owner: Pekka Pessi <pekka.pessi@nokia.com>
+
+
 Miscellaneous
 =============
 
diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
index 7877ac5..bc79fc3 100644
--- a/doc/voicecallmanager-api.txt
+++ b/doc/voicecallmanager-api.txt
@@ -108,10 +108,10 @@ Methods		dict GetProperties()
 
 		void SendTones(string tones)
 
-			Sends the DTMF tones to the network.  Under GSM the
-			tones have a fixed duration.  Tones can be one of:
-			'0' - '9', '*', '#', 'A', 'B', 'C', 'D'. The last four
-			are typically not used in normal circumstances.
+			Sends the DTMF tones to the network.  The tones have
+			a fixed duration.  Tones can be one of: '0' - '9',
+			'*', '#', 'A', 'B', 'C', 'D'.  The last four are
+			typically not used in normal circumstances.
 
 Signals		PropertyChanged(string property, variant value)
 
-- 
1.7.0.4

Re: [PATCH] Voicecall gaps.

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi Pekka,

On 07/05/2010 08:40 AM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi <Pekka.Pessi@nokia.com>
> 
> Missing voicecall functionality pieces from tp-ring point-of-view.
> ---
>  TODO                         |   27 +++++++++++++++++++++++++++
>  doc/voicecallmanager-api.txt |    8 ++++----
>  2 files changed, 31 insertions(+), 4 deletions(-)

Please don't lump TODO and documentation changes into a single patch.
Separate into two patches.

Regards,
-Denis