* [PATCH] dbus: fix building for mipsel. @ 2010-06-30 4:24 Graham Gower 2010-06-30 6:38 ` [PATCH v2] dbus: fix building for mipsel and fix PIE segfault issue (again) Graham Gower 2010-07-01 7:02 ` [PATCH] dbus: fix building for mipsel Khem Raj 0 siblings, 2 replies; 6+ messages in thread From: Graham Gower @ 2010-06-30 4:24 UTC (permalink / raw) To: openembedded-devel Mipsel lives in a bizarro world where the following error happens: | CCLD dbus-daemon-launch-helper | /home/grg/oe2/tmp/cross/mipsel/lib/gcc/mipsel-oe-linux/4.4.4/../../../../mipsel-oe-linux/bin/ld: can not make stub section: File format not recognized | /home/grg/oe2/tmp/cross/mipsel/lib/gcc/mipsel-oe-linux/4.4.4/../../../../mipsel-oe-linux/bin/ld: failed to set dynamic section sizes: File format not recognized | collect2: ld returned 1 exit status Fix as noted by the openwrt folks: https://dev.openwrt.org/changeset/18308 Signed-off-by: Graham Gower <graham.gower@gmail.com> --- recipes/dbus/dbus.inc | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/recipes/dbus/dbus.inc b/recipes/dbus/dbus.inc index ec66960..41ec9d1 100644 --- a/recipes/dbus/dbus.inc +++ b/recipes/dbus/dbus.inc @@ -38,6 +38,9 @@ EXTRA_OECONF = "\ do_compile_prepend_mipsel() { sed -i -e 's/\-fPIE//' -e 's/\-pie\ \-Wl\,\-z\,relro//' bus/Makefile } +do_configure_prepend_mipsel() { + sed -i -e 's/-Wl,--gc-sections/--gc-sections/' ${S}/configure +} do_install_append() { install -d ${D}${sysconfdir}/init.d -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] dbus: fix building for mipsel and fix PIE segfault issue (again). 2010-06-30 4:24 [PATCH] dbus: fix building for mipsel Graham Gower @ 2010-06-30 6:38 ` Graham Gower 2010-07-02 0:39 ` [PATCH v3] dbus: fix building on mipsel and clean up PIE/pie fix to work again Graham Gower 2010-07-01 7:02 ` [PATCH] dbus: fix building for mipsel Khem Raj 1 sibling, 1 reply; 6+ messages in thread From: Graham Gower @ 2010-06-30 6:38 UTC (permalink / raw) To: openembedded-devel Subject: [PATCH v2] dbus: fix building for mipsel and fix PIE segfault issue (again). Previous fPIE fix no longer works. Signed-off-by: Graham Gower <graham.gower@gmail.com> --- recipes/dbus/dbus.inc | 9 ++++++--- recipes/dbus/dbus_1.2.20.bb | 2 ++ recipes/dbus/dbus_1.2.22.bb | 2 ++ recipes/dbus/dbus_1.2.24.bb | 2 ++ recipes/dbus/dbus_1.3.0.bb | 4 ++-- 5 files changed, 14 insertions(+), 5 deletions(-) diff --git a/recipes/dbus/dbus.inc b/recipes/dbus/dbus.inc index ec66960..baf3139 100644 --- a/recipes/dbus/dbus.inc +++ b/recipes/dbus/dbus.inc @@ -4,7 +4,7 @@ SECTION = "base" LICENSE = "GPL" DEPENDS = "expat glib-2.0 virtual/libintl libsm libice virtual/libx11" -INC_PR = "r18" +INC_PR = "r19" SRC_URI = "\ http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ @@ -35,8 +35,11 @@ EXTRA_OECONF = "\ ${EXTRA_OECONF_X} \ " -do_compile_prepend_mipsel() { - sed -i -e 's/\-fPIE//' -e 's/\-pie\ \-Wl\,\-z\,relro//' bus/Makefile +do_configure_prepend_mipsel() { + sed -i -e 's/\-fPIE//' \ + -e 's/\-pie\ \-Wl\,\-z\,relro//' \ + -e 's/-Wl,--gc-sections/--gc-sections/' \ + ${S}/configure.in } do_install_append() { diff --git a/recipes/dbus/dbus_1.2.20.bb b/recipes/dbus/dbus_1.2.20.bb index 43805a5..25cc5ac 100644 --- a/recipes/dbus/dbus_1.2.20.bb +++ b/recipes/dbus/dbus_1.2.20.bb @@ -1,5 +1,7 @@ include dbus.inc +PR = "${INC_PR}.0" + SRC_URI = "\ http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ file://tmpdir.patch \ diff --git a/recipes/dbus/dbus_1.2.22.bb b/recipes/dbus/dbus_1.2.22.bb index 35a5267..74386ed 100644 --- a/recipes/dbus/dbus_1.2.22.bb +++ b/recipes/dbus/dbus_1.2.22.bb @@ -1,5 +1,7 @@ include dbus.inc +PR = "${INC_PR}.0" + SRC_URI = "\ http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ file://tmpdir.patch \ diff --git a/recipes/dbus/dbus_1.2.24.bb b/recipes/dbus/dbus_1.2.24.bb index 4e408e7..a2b7eea 100644 --- a/recipes/dbus/dbus_1.2.24.bb +++ b/recipes/dbus/dbus_1.2.24.bb @@ -1,5 +1,7 @@ include dbus.inc +PR = "${INC_PR}.0" + SRC_URI = "\ http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ file://tmpdir.patch \ diff --git a/recipes/dbus/dbus_1.3.0.bb b/recipes/dbus/dbus_1.3.0.bb index 830816f..a923166 100644 --- a/recipes/dbus/dbus_1.3.0.bb +++ b/recipes/dbus/dbus_1.3.0.bb @@ -1,5 +1,7 @@ include dbus.inc +PR = "${INC_PR}.0" + SRC_URI = "\ http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \ \ @@ -20,7 +22,5 @@ SRC_URI = "\ # This is the development version of dbus that will lead to 1.4.x DEFAULT_PREFERENCE = "-1" -PR = "r2" - SRC_URI[md5sum] = "b3298d5ce0e4ad4731b1e4e1787d56bb" SRC_URI[sha256sum] = "fe32b49667894cf91b0a97503163be5c4814ecf67259e8feb26d1ba57cb03dae" -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3] dbus: fix building on mipsel and clean up PIE/pie fix to work again. 2010-06-30 6:38 ` [PATCH v2] dbus: fix building for mipsel and fix PIE segfault issue (again) Graham Gower @ 2010-07-02 0:39 ` Graham Gower 2010-07-02 3:15 ` Khem Raj 0 siblings, 1 reply; 6+ messages in thread From: Graham Gower @ 2010-07-02 0:39 UTC (permalink / raw) To: openembedded-devel Subject: [PATCH v3] dbus: fix building on mipsel and clean up PIE/pie fix to work again. D-Bus fails to link with --gc-sections on mipsel. | CCLD dbus-daemon | collect2: ld returned 1 exit status | make[2]: *** [dbus-daemon] Error 1 | make[2]: *** Waiting for unfinished jobs.... | /home/grg/oe2/tmp/cross/mipsel/lib/gcc/mipsel-oe-linux/4.4.4/../../../../mipsel-oe-linux/bin/ld: can not make stub section: File format not recognized | /home/grg/oe2/tmp/cross/mipsel/lib/gcc/mipsel-oe-linux/4.4.4/../../../../mipsel-oe-linux/bin/ld: failed to set dynamic section sizes: File format not recognized Also, the previous fPIE/pie fix no longer works. While here, clean up INC_PR. Signed-off-by: Graham Gower <graham.gower@gmail.com> --- recipes/dbus/dbus.inc | 11 ++++++++--- recipes/dbus/dbus_1.2.20.bb | 2 ++ recipes/dbus/dbus_1.2.22.bb | 2 ++ recipes/dbus/dbus_1.2.24.bb | 2 ++ recipes/dbus/dbus_1.3.0.bb | 4 ++-- 5 files changed, 16 insertions(+), 5 deletions(-) diff --git a/recipes/dbus/dbus.inc b/recipes/dbus/dbus.inc index ec66960..55a156d 100644 --- a/recipes/dbus/dbus.inc +++ b/recipes/dbus/dbus.inc @@ -4,7 +4,7 @@ SECTION = "base" LICENSE = "GPL" DEPENDS = "expat glib-2.0 virtual/libintl libsm libice virtual/libx11" -INC_PR = "r18" +INC_PR = "r19" SRC_URI = "\ http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ @@ -35,8 +35,13 @@ EXTRA_OECONF = "\ ${EXTRA_OECONF_X} \ " -do_compile_prepend_mipsel() { - sed -i -e 's/\-fPIE//' -e 's/\-pie\ \-Wl\,\-z\,relro//' bus/Makefile +# On mipsel, D-Bus fails to link with --gc-sections and segfaults before main() +# when built with -fPIE/-pie. +do_configure_prepend_mipsel() { + sed -i -e 's/\-fPIE//' \ + -e 's/\-pie\ \-Wl\,\-z\,relro//' \ + -e 's/-Wl,--gc-sections//' \ + ${S}/configure.in } do_install_append() { diff --git a/recipes/dbus/dbus_1.2.20.bb b/recipes/dbus/dbus_1.2.20.bb index 43805a5..25cc5ac 100644 --- a/recipes/dbus/dbus_1.2.20.bb +++ b/recipes/dbus/dbus_1.2.20.bb @@ -1,5 +1,7 @@ include dbus.inc +PR = "${INC_PR}.0" + SRC_URI = "\ http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ file://tmpdir.patch \ diff --git a/recipes/dbus/dbus_1.2.22.bb b/recipes/dbus/dbus_1.2.22.bb index 35a5267..74386ed 100644 --- a/recipes/dbus/dbus_1.2.22.bb +++ b/recipes/dbus/dbus_1.2.22.bb @@ -1,5 +1,7 @@ include dbus.inc +PR = "${INC_PR}.0" + SRC_URI = "\ http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ file://tmpdir.patch \ diff --git a/recipes/dbus/dbus_1.2.24.bb b/recipes/dbus/dbus_1.2.24.bb index 4e408e7..a2b7eea 100644 --- a/recipes/dbus/dbus_1.2.24.bb +++ b/recipes/dbus/dbus_1.2.24.bb @@ -1,5 +1,7 @@ include dbus.inc +PR = "${INC_PR}.0" + SRC_URI = "\ http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ file://tmpdir.patch \ diff --git a/recipes/dbus/dbus_1.3.0.bb b/recipes/dbus/dbus_1.3.0.bb index 830816f..a923166 100644 --- a/recipes/dbus/dbus_1.3.0.bb +++ b/recipes/dbus/dbus_1.3.0.bb @@ -1,5 +1,7 @@ include dbus.inc +PR = "${INC_PR}.0" + SRC_URI = "\ http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \ \ @@ -20,7 +22,5 @@ SRC_URI = "\ # This is the development version of dbus that will lead to 1.4.x DEFAULT_PREFERENCE = "-1" -PR = "r2" - SRC_URI[md5sum] = "b3298d5ce0e4ad4731b1e4e1787d56bb" SRC_URI[sha256sum] = "fe32b49667894cf91b0a97503163be5c4814ecf67259e8feb26d1ba57cb03dae" -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] dbus: fix building on mipsel and clean up PIE/pie fix to work again. 2010-07-02 0:39 ` [PATCH v3] dbus: fix building on mipsel and clean up PIE/pie fix to work again Graham Gower @ 2010-07-02 3:15 ` Khem Raj 0 siblings, 0 replies; 6+ messages in thread From: Khem Raj @ 2010-07-02 3:15 UTC (permalink / raw) To: openembedded-devel On Thu, Jul 1, 2010 at 5:39 PM, Graham Gower <graham.gower@gmail.com> wrote: > Subject: [PATCH v3] dbus: fix building on mipsel and clean up PIE/pie fix to work again. > > D-Bus fails to link with --gc-sections on mipsel. > > | CCLD dbus-daemon > | collect2: ld returned 1 exit status > | make[2]: *** [dbus-daemon] Error 1 > | make[2]: *** Waiting for unfinished jobs.... > | /home/grg/oe2/tmp/cross/mipsel/lib/gcc/mipsel-oe-linux/4.4.4/../../../../mipsel-oe-linux/bin/ld: can not make stub section: File format not recognized > | /home/grg/oe2/tmp/cross/mipsel/lib/gcc/mipsel-oe-linux/4.4.4/../../../../mipsel-oe-linux/bin/ld: failed to set dynamic section sizes: File format not recognized > > Also, the previous fPIE/pie fix no longer works. > While here, clean up INC_PR. > > Signed-off-by: Graham Gower <graham.gower@gmail.com> looks good. Acked-by: Khem Raj <raj.khem@gmail.com> > --- > recipes/dbus/dbus.inc | 11 ++++++++--- > recipes/dbus/dbus_1.2.20.bb | 2 ++ > recipes/dbus/dbus_1.2.22.bb | 2 ++ > recipes/dbus/dbus_1.2.24.bb | 2 ++ > recipes/dbus/dbus_1.3.0.bb | 4 ++-- > 5 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/recipes/dbus/dbus.inc b/recipes/dbus/dbus.inc > index ec66960..55a156d 100644 > --- a/recipes/dbus/dbus.inc > +++ b/recipes/dbus/dbus.inc > @@ -4,7 +4,7 @@ SECTION = "base" > LICENSE = "GPL" > DEPENDS = "expat glib-2.0 virtual/libintl libsm libice virtual/libx11" > > -INC_PR = "r18" > +INC_PR = "r19" > > SRC_URI = "\ > http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ > @@ -35,8 +35,13 @@ EXTRA_OECONF = "\ > ${EXTRA_OECONF_X} \ > " > > -do_compile_prepend_mipsel() { > - sed -i -e 's/\-fPIE//' -e 's/\-pie\ \-Wl\,\-z\,relro//' bus/Makefile > +# On mipsel, D-Bus fails to link with --gc-sections and segfaults before main() > +# when built with -fPIE/-pie. > +do_configure_prepend_mipsel() { > + sed -i -e 's/\-fPIE//' \ > + -e 's/\-pie\ \-Wl\,\-z\,relro//' \ > + -e 's/-Wl,--gc-sections//' \ > + ${S}/configure.in > } > > do_install_append() { > diff --git a/recipes/dbus/dbus_1.2.20.bb b/recipes/dbus/dbus_1.2.20.bb > index 43805a5..25cc5ac 100644 > --- a/recipes/dbus/dbus_1.2.20.bb > +++ b/recipes/dbus/dbus_1.2.20.bb > @@ -1,5 +1,7 @@ > include dbus.inc > > +PR = "${INC_PR}.0" > + > SRC_URI = "\ > http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ > file://tmpdir.patch \ > diff --git a/recipes/dbus/dbus_1.2.22.bb b/recipes/dbus/dbus_1.2.22.bb > index 35a5267..74386ed 100644 > --- a/recipes/dbus/dbus_1.2.22.bb > +++ b/recipes/dbus/dbus_1.2.22.bb > @@ -1,5 +1,7 @@ > include dbus.inc > > +PR = "${INC_PR}.0" > + > SRC_URI = "\ > http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ > file://tmpdir.patch \ > diff --git a/recipes/dbus/dbus_1.2.24.bb b/recipes/dbus/dbus_1.2.24.bb > index 4e408e7..a2b7eea 100644 > --- a/recipes/dbus/dbus_1.2.24.bb > +++ b/recipes/dbus/dbus_1.2.24.bb > @@ -1,5 +1,7 @@ > include dbus.inc > > +PR = "${INC_PR}.0" > + > SRC_URI = "\ > http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz;name=dbus \ > file://tmpdir.patch \ > diff --git a/recipes/dbus/dbus_1.3.0.bb b/recipes/dbus/dbus_1.3.0.bb > index 830816f..a923166 100644 > --- a/recipes/dbus/dbus_1.3.0.bb > +++ b/recipes/dbus/dbus_1.3.0.bb > @@ -1,5 +1,7 @@ > include dbus.inc > > +PR = "${INC_PR}.0" > + > SRC_URI = "\ > http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \ > \ > @@ -20,7 +22,5 @@ SRC_URI = "\ > # This is the development version of dbus that will lead to 1.4.x > DEFAULT_PREFERENCE = "-1" > > -PR = "r2" > - > SRC_URI[md5sum] = "b3298d5ce0e4ad4731b1e4e1787d56bb" > SRC_URI[sha256sum] = "fe32b49667894cf91b0a97503163be5c4814ecf67259e8feb26d1ba57cb03dae" > -- > 1.7.1 > > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dbus: fix building for mipsel. 2010-06-30 4:24 [PATCH] dbus: fix building for mipsel Graham Gower 2010-06-30 6:38 ` [PATCH v2] dbus: fix building for mipsel and fix PIE segfault issue (again) Graham Gower @ 2010-07-01 7:02 ` Khem Raj 2010-07-01 7:18 ` Graham Gower 1 sibling, 1 reply; 6+ messages in thread From: Khem Raj @ 2010-07-01 7:02 UTC (permalink / raw) To: openembedded-devel On Tue, Jun 29, 2010 at 9:24 PM, Graham Gower <graham.gower@gmail.com> wrote: > Mipsel lives in a bizarro world where the following error happens: > > | CCLD dbus-daemon-launch-helper > | /home/grg/oe2/tmp/cross/mipsel/lib/gcc/mipsel-oe-linux/4.4.4/../../../../mipsel-oe-linux/bin/ld: can not make stub section: File format not recognized > | /home/grg/oe2/tmp/cross/mipsel/lib/gcc/mipsel-oe-linux/4.4.4/../../../../mipsel-oe-linux/bin/ld: failed to set dynamic section sizes: File format not recognized > | collect2: ld returned 1 exit status > > Fix as noted by the openwrt folks: > https://dev.openwrt.org/changeset/18308 > > Signed-off-by: Graham Gower <graham.gower@gmail.com> > --- > recipes/dbus/dbus.inc | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/recipes/dbus/dbus.inc b/recipes/dbus/dbus.inc > index ec66960..41ec9d1 100644 > --- a/recipes/dbus/dbus.inc > +++ b/recipes/dbus/dbus.inc > @@ -38,6 +38,9 @@ EXTRA_OECONF = "\ > do_compile_prepend_mipsel() { > sed -i -e 's/\-fPIE//' -e 's/\-pie\ \-Wl\,\-z\,relro//' bus/Makefile > } > +do_configure_prepend_mipsel() { > + sed -i -e 's/-Wl,--gc-sections/--gc-sections/' ${S}/configure > +} this changes this to be a compiler option instead of gcc driver passing it to link step and gcc does not have such option so it should error out. I wonder how does this work. just removing it fully would be understandable if say gc-sections does not work in ld. > > do_install_append() { > install -d ${D}${sysconfdir}/init.d > -- > 1.7.1 > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dbus: fix building for mipsel. 2010-07-01 7:02 ` [PATCH] dbus: fix building for mipsel Khem Raj @ 2010-07-01 7:18 ` Graham Gower 0 siblings, 0 replies; 6+ messages in thread From: Graham Gower @ 2010-07-01 7:18 UTC (permalink / raw) To: openembedded-devel On 1 July 2010 16:32, Khem Raj <raj.khem@gmail.com> wrote: > On Tue, Jun 29, 2010 at 9:24 PM, Graham Gower <graham.gower@gmail.com> wrote: >> Mipsel lives in a bizarro world where the following error happens: >> >> | CCLD dbus-daemon-launch-helper >> | /home/grg/oe2/tmp/cross/mipsel/lib/gcc/mipsel-oe-linux/4.4.4/../../../../mipsel-oe-linux/bin/ld: can not make stub section: File format not recognized >> | /home/grg/oe2/tmp/cross/mipsel/lib/gcc/mipsel-oe-linux/4.4.4/../../../../mipsel-oe-linux/bin/ld: failed to set dynamic section sizes: File format not recognized >> | collect2: ld returned 1 exit status >> >> Fix as noted by the openwrt folks: >> https://dev.openwrt.org/changeset/18308 >> >> Signed-off-by: Graham Gower <graham.gower@gmail.com> >> --- >> recipes/dbus/dbus.inc | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/recipes/dbus/dbus.inc b/recipes/dbus/dbus.inc >> index ec66960..41ec9d1 100644 >> --- a/recipes/dbus/dbus.inc >> +++ b/recipes/dbus/dbus.inc >> @@ -38,6 +38,9 @@ EXTRA_OECONF = "\ >> do_compile_prepend_mipsel() { >> sed -i -e 's/\-fPIE//' -e 's/\-pie\ \-Wl\,\-z\,relro//' bus/Makefile >> } >> +do_configure_prepend_mipsel() { >> + sed -i -e 's/-Wl,--gc-sections/--gc-sections/' ${S}/configure >> +} > > this changes this to be a compiler option instead of > gcc driver passing it to link step and gcc does not > have such option so it should error out. I wonder how > does this work. just removing it fully would be > understandable if say gc-sections does not work in ld. Hmmm. Right you are. Digging further, I see the configure script checks if gcc compiles a dummy program with those options and uses them if it succeeds. Gcc does indeed error out in this case, causing the configure script to not use --gc-sections. -Graham ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-02 3:20 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-06-30 4:24 [PATCH] dbus: fix building for mipsel Graham Gower 2010-06-30 6:38 ` [PATCH v2] dbus: fix building for mipsel and fix PIE segfault issue (again) Graham Gower 2010-07-02 0:39 ` [PATCH v3] dbus: fix building on mipsel and clean up PIE/pie fix to work again Graham Gower 2010-07-02 3:15 ` Khem Raj 2010-07-01 7:02 ` [PATCH] dbus: fix building for mipsel Khem Raj 2010-07-01 7:18 ` Graham Gower
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.