All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>,
	KVM mailing list <kvm@vger.kernel.org>,
	qemu mailing list <qemu-devel@nongnu.org>,
	Michael Goldish <mgoldish@redhat.com>,
	Jes Sorensen <Jes.Sorensen@redhat.com>,
	Dor Laor <dlaor@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: qemu-kvm.git unittest failures
Date: Sat, 03 Jul 2010 13:25:58 +0300	[thread overview]
Message-ID: <4C2F1036.6030406@redhat.com> (raw)
In-Reply-To: <20100702224424.GA6731@amt.cnet>

On 07/03/2010 01:44 AM, Marcelo Tosatti wrote:
>
>> Config entry:
>>
>> [access]
>> file = access.flat
>>
>> Massive log, compressed and attached.
>>      
> run
> test pde.p user: FAIL: error code 5 expected 4
> test pte.rw pde.p user: FAIL: error code 5 expected 4
> test pte.user pde.p user: FAIL: error code 5 expected 4
> test pte.rw pte.user pde.p user: FAIL: error code 5 expected 4
> test pte.a pde.p user: FAIL: error code 5 expected 4
> test pte.rw pte.a pde.p user: FAIL: error code 5 expected 4
> test pte.user pte.a pde.p user: FAIL: error code 5 expected 4
>
> P flag (bit 0).
> This flag is 0 if there is no valid translation for the linear address
> because the P
> flag was 0 in one of the paging-structure entries used to translate that
> address.
>
> Avi, a walk ignoring access permissions should be done to properly set
> the P flag on error code. Does anybody care?
>    

Probably not, but best to be compatible with real hardware.

We could simply continue the existing walk, just set a flag indicating 
that it can't succeed.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	KVM mailing list <kvm@vger.kernel.org>,
	Michael Goldish <mgoldish@redhat.com>,
	Dor Laor <dlaor@redhat.com>,
	qemu mailing list <qemu-devel@nongnu.org>,
	Jes Sorensen <Jes.Sorensen@redhat.com>
Subject: [Qemu-devel] Re: qemu-kvm.git unittest failures
Date: Sat, 03 Jul 2010 13:25:58 +0300	[thread overview]
Message-ID: <4C2F1036.6030406@redhat.com> (raw)
In-Reply-To: <20100702224424.GA6731@amt.cnet>

On 07/03/2010 01:44 AM, Marcelo Tosatti wrote:
>
>> Config entry:
>>
>> [access]
>> file = access.flat
>>
>> Massive log, compressed and attached.
>>      
> run
> test pde.p user: FAIL: error code 5 expected 4
> test pte.rw pde.p user: FAIL: error code 5 expected 4
> test pte.user pde.p user: FAIL: error code 5 expected 4
> test pte.rw pte.user pde.p user: FAIL: error code 5 expected 4
> test pte.a pde.p user: FAIL: error code 5 expected 4
> test pte.rw pte.a pde.p user: FAIL: error code 5 expected 4
> test pte.user pte.a pde.p user: FAIL: error code 5 expected 4
>
> P flag (bit 0).
> This flag is 0 if there is no valid translation for the linear address
> because the P
> flag was 0 in one of the paging-structure entries used to translate that
> address.
>
> Avi, a walk ignoring access permissions should be done to properly set
> the P flag on error code. Does anybody care?
>    

Probably not, but best to be compatible with real hardware.

We could simply continue the existing walk, just set a flag indicating 
that it can't succeed.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

  reply	other threads:[~2010-07-03 10:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1278001551.2659.308.camel@freedom>
2010-07-02 22:44 ` qemu-kvm.git unittest failures Marcelo Tosatti
2010-07-02 22:44   ` [Qemu-devel] " Marcelo Tosatti
2010-07-03 10:25   ` Avi Kivity [this message]
2010-07-03 10:25     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C2F1036.6030406@redhat.com \
    --to=avi@redhat.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=dlaor@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lmr@redhat.com \
    --cc=mgoldish@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.